Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuLpr-000053-Eo for pgsql-hackers@arkaria.postgresql.org; Thu, 26 May 2022 22:20:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nuLpq-0008TM-DB for pgsql-hackers@arkaria.postgresql.org; Thu, 26 May 2022 22:20:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuLpq-0008T2-41 for pgsql-hackers@lists.postgresql.org; Thu, 26 May 2022 22:20:02 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuLpo-0006tT-0p for pgsql-hackers@postgresql.org; Thu, 26 May 2022 22:20:01 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 24QMJu9C2464543; Thu, 26 May 2022 18:19:56 -0400 From: Tom Lane To: Michael Paquier cc: Justin Pryzby , Peter Eisentraut , pgsql-hackers@postgresql.org Subject: Re: pg_upgrade test writes to source directory In-reply-to: References: <20220526205218.GC19626@telsasoft.com> Comments: In-reply-to Michael Paquier message dated "Fri, 27 May 2022 07:03:30 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2464541.1653603596.1@sss.pgh.pa.us> Date: Thu, 26 May 2022 18:19:56 -0400 Message-ID: <2464542.1653603596@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Thu, May 26, 2022 at 03:52:18PM -0500, Justin Pryzby wrote: >> It looks like Peter working on top of the meson branch. >> TESTOUTDIR is not yet in master. > Well, we need to do something about that on HEAD, and it also means > that TESTDIR is the best fit for the job now, except if the variable > split happens before REL_15_STABLE is forked. It looks like that patch is meant to resolve misbehaviors equivalent to this one that already exist in several other places. So fixing this one along with the other ones seems like an appropriate thing to do when that lands. regards, tom lane