From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: Victor Wagner <vitus@wagner.pp.ru>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Non-portable shell code in pg_upgrade tap tests
In-reply-to: <20180722173857.GA3998719@rfd.leadboat.com>
References: <20180720153820.69e9ae6c@fafnir.local.vm>
 <17833.1532096747@sss.pgh.pa.us> <20180720175508.07776219@fafnir.local.vm>
 <20015.1532099353@sss.pgh.pa.us> <20180722072904.GA3951499@rfd.leadboat.com>
 <6519.1532270763@sss.pgh.pa.us> <20180722173857.GA3998719@rfd.leadboat.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sun, 22 Jul 2018 10:38:57 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24716.1532285631.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 22 Jul 2018 14:53:51 -0400
Message-ID: <24717.1532285631@sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> On Sun, Jul 22, 2018 at 10:46:03AM -0400, Tom Lane wrote:
>> The pg_upgrade makefile does in fact use $(SHELL), so it will default t=
o
>> whatever shell configure used.

> It will not, because we don't set $(SHELL) anywhere.  $(SHELL) is not @S=
HELL@.
> In our makefiles, $(SHELL) is always /bin/sh, the GNU make default.

Oh!  Hm, I wonder whether we shouldn't do that, ie add SHELL =3D @SHELL@
to Makefile.global.in.

A quick trawl of the buildfarm logs says most of our animals compute
SHELL =3D /bin/sh anyway, and so would be unaffected.  There's a sizable
population that find /bin/bash though, and one active critter that finds
/bin/ksh.

			regards, tom lane