Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hrr8q-0003fT-7d for pgsql-hackers@arkaria.postgresql.org; Sun, 28 Jul 2019 21:55:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hrr8o-0001lD-SH for pgsql-hackers@arkaria.postgresql.org; Sun, 28 Jul 2019 21:55:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hrr8o-0001l6-GP for pgsql-hackers@lists.postgresql.org; Sun, 28 Jul 2019 21:55:42 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1hrr8m-0002dU-DI for pgsql-hackers@lists.postgresql.org; Sun, 28 Jul 2019 21:55:41 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x6SLtXwB024730; Sun, 28 Jul 2019 17:55:33 -0400 From: Tom Lane To: Thomas Munro cc: Fabien COELHO , didier , Alvaro Herrera , Pg Hackers , buildfarm@coelho.net Subject: Re: LLVM compile failing in seawasp In-reply-to: References: <20190606173216.GA6306@alvherre.pgsql> <5762.1559866377@sss.pgh.pa.us> <24644.1564322045@sss.pgh.pa.us> Comments: In-reply-to Thomas Munro message dated "Mon, 29 Jul 2019 09:50:32 +1200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <24728.1564350933.1@sss.pgh.pa.us> Date: Sun, 28 Jul 2019 17:55:33 -0400 Message-ID: <24729.1564350933@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Thomas Munro writes: > Let's just commit the #undef so that seawasp is green and back to > being ready to tell us if something else breaks. +1. I was afraid that working around this would be impossibly painful ... but if it just takes one judiciously placed #undef, let's do that and not argue about it. regards, tom lane