From: Tom Lane <tgl@sss.pgh.pa.us>
To: Corey Huinker <corey.huinker@gmail.com>
cc: Fabien COELHO <coelho@cri.ensmp.fr>,
        Daniel Verite <daniel@manitou-mail.org>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        Greg Stark <stark@mit.edu>, Erik Rijkers <er@xs4all.nl>,
        Robert Haas <robertmhaas@gmail.com>,
        Jim Nasby <Jim.Nasby@bluetreble.com>,
        PostgreSQL <pgsql-hackers@postgresql.org>,
        pgsql-hackers-owner@postgresql.org
Subject: Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if,
 \quit_unless)
In-reply-to: 
 <CADkLM=eUksHSUc_HXE8CRFgj85C8cABVfVY1hRoTfdNvwwOUGg@mail.gmail.com>
References: <df2c433c-b9ff-4d41-ad08-b0d420b403b8@manitou-mail.org>
 <15541.1489771669@sss.pgh.pa.us>
 <CADkLM=eCT_UcWN+q_9OWjJqK_d82uxvynJcLAPOMiQLaJ-W-ZA@mail.gmail.com>
 <CADkLM=f3_Sf2EHNBFgLWUA-1PRSJ-qVmyVqFuHjXEgLPWjaJtw@mail.gmail.com>
 <alpine.DEB.2.20.1703241717220.28545@lancre>
 <CADkLM=cfm2ZhHP=4hqydT6DMAYT3G0t5YrxhPR+yCg0aOwiTDw@mail.gmail.com>
 <alpine.DEB.2.20.1703242047000.8361@lancre>
 <CADkLM=ecKDEyBAOx3fRFtqJb0VqsR+y4-OSzWHS_hMPJ0UD_Rg@mail.gmail.com>
 <alpine.DEB.2.20.1703250719430.8361@lancre>
 <CADkLM=esbih=DF97=87UjpT-8JjYnLCBy_NFMyM0vs-0jzYe3A@mail.gmail.com>
 <alpine.DEB.2.20.1703251857540.8361@lancre>
 <CADkLM=dZt6eJQD1pQ7GXUeP83Ut_N+RaRsCgDj+Cpx_bV=LLsg@mail.gmail.com>
 <alpine.DEB.2.20.1703270655240.20202@lancre>
 <CADkLM=fbEGfea0idN_XsKUG70JmCaMjdejo35q-B5tpC11NTuA@mail.gmail.com>
 <alpine.DEB.2.20.1703271631250.10424@lancre>
 <CADkLM=czttdEn1fVMb-qAQDvteXU3SOv47GsKbea9+iaYbCK_w@mail.gmail.com>
 <alpine.DEB.2.20.1703272110480.19631@lancre> <CADkLM=f6ELXZOmW9UU3vyY!
 u3jzTbh2o2178r7+wt2emN+DWmig@mail.gmail.com>
 <CADkLM=eUksHSUc_HXE8CRFgj85C8cABVfVY1hRoTfdNvwwOUGg@mail.gmail.com>
Comments: In-reply-to Corey Huinker <corey.huinker@gmail.com>
	message dated "Mon, 27 Mar 2017 15:53:18 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24979.1490748720.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 28 Mar 2017 20:52:00 -0400
Message-ID: <24980.1490748720@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Corey Huinker <corey.huinker@gmail.com> writes:
[ 0001-psql-if-v28.patch ]

Starting to look at this version, and what jumped out at me in testing
is that the regression output looks like this:

parallel group (12 tests):  psql_if_on_error_stop dbsize async misc_functio=
ns tidscan alter_operator tsrf psql alter_generic misc stats_ext sysviews
     alter_generic            ... ok
     alter_operator           ... ok
     misc                     ... ok
     psql                     ... ok
     psql_if_on_error_stop    ... ok (test process exited with exit code 3)
     async                    ... ok
     dbsize                   ... ok
     misc_functions           ... ok
     sysviews                 ... ok
     tsrf                     ... ok
     tidscan                  ... ok
     stats_ext                ... ok

Don't think we can have that.  Even if pg_regress considers it a success,
every hacker is going to have to learn that that's a "pass", and I don't
think I want to be answering that question every week till kingdom come.

I'm not really sure we need a test for this behavior.  If we're
sufficiently dead set on it, we could go back to the TAP-based approach,
but I still doubt that this test is worth the amount of overhead that
would add.

			regards, tom lane


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers