Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMAA8-0005EG-4S for pgsql-hackers@arkaria.postgresql.org; Fri, 03 Sep 2021 14:27:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAA7-0004C6-4J for pgsql-hackers@arkaria.postgresql.org; Fri, 03 Sep 2021 14:27:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMAA6-0004By-T0 for pgsql-hackers@lists.postgresql.org; Fri, 03 Sep 2021 14:27:22 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMAA4-0003uN-U0 for pgsql-hackers@postgresql.org; Fri, 03 Sep 2021 14:27:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 183ERDQi2498303; Fri, 3 Sep 2021 10:27:13 -0400 From: Tom Lane To: Fujii Masao cc: Kyotaro Horiguchi , noriyoshi.shinoda@hpe.com, rjuju123@gmail.com, pgsql-hackers@postgresql.org Subject: Re: Improve logging when using Huge Pages In-reply-to: <1946f6b9-75a1-7aeb-7b06-6c018377e518@oss.nttdata.com> References: <7e5b9f6d-1db9-d1e2-3bd8-ef65f24b35be@oss.nttdata.com> <20210903.164934.1726669051525427478.horikyota.ntt@gmail.com> <1946f6b9-75a1-7aeb-7b06-6c018377e518@oss.nttdata.com> Comments: In-reply-to Fujii Masao message dated "Fri, 03 Sep 2021 22:37:33 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2498301.1630679233.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 03 Sep 2021 10:27:13 -0400 Message-ID: <2498302.1630679233@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Fujii Masao writes: > IMO, if the level is promoted to LOG, the message should be updated > so that it follows the error message style guide. But I agree that simpl= er > message would be better in this case. So what about something like > the following? > LOG: could not map anonymous shared memory (%zu bytes) with huge pages e= nabled > HINT: The server will map anonymous shared memory again with huge pages = disabled. That is not a hint. Maybe it qualifies as errdetail, though. regards, tom lane