From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
cc: pgsql-hackers@postgresql.org
Subject: Re: pg_dump -s -b
In-reply-to: <20161119170835.GZ13284@tamriel.snowman.net>
References: <20161119170835.GZ13284@tamriel.snowman.net>
Comments: In-reply-to Stephen Frost <sfrost@snowman.net>
	message dated "Sat, 19 Nov 2016 12:08:35 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24986.1479576007.1@sss.pgh.pa.us>
Date: Sat, 19 Nov 2016 12:20:07 -0500
Message-ID: <24987.1479576007@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Stephen Frost <sfrost@snowman.net> writes:
> To wit, our docs specifically say:
> ----
> Include large objects in the dump. This is the default behavior except
> when --schema, --table, or --schema-only is specified, so the -b switch
> is only useful to add large objects to selective dumps.
> ----

Clearly, this is an oversimplification.

> However, a 'pg_dump -s -b' won't include blobs, which appears to be due
> to the masking performed in _tocEntryRequired() whereby we strip the
> REQ_DATA out if we are in schema-only mode.
> Further, though perhaps less surprising, we don't include blobs when
> --section=post-data is set, and only the definition of the blob (but no
> data) when --section=pre-data is used.

IMO, blobs are data, so those behaviors are correct.  The docs should
be fixed to match the code.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers