From: Tom Lane <tgl@sss.pgh.pa.us>
To: "=?UTF-8?B?6JSh5qKm5aifKOeOiuS6jik=?=" <mengjuan.cmj@alibaba-inc.com>
cc: "pgsql-hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re:
 =?UTF-8?B?QWRkIGd1YyB0byBlbmFibGUgc2VuZCBTSUdTVE9QIHRvIHBlZXJzIHdoZW4gYmFja2VuZCBl?=
 =?UTF-8?B?eGl0cyBhYm5vcm1hbGx5?=
In-reply-to: 
 <1a53af38-851a-4ad0-9ff1-54e7b8aeca73.mengjuan.cmj@alibaba-inc.com>
References: 
 <1a53af38-851a-4ad0-9ff1-54e7b8aeca73.mengjuan.cmj@alibaba-inc.com>
Comments: In-reply-to "=?UTF-8?B?6JSh5qKm5aifKOeOiuS6jik=?="
 <mengjuan.cmj@alibaba-inc.com>
	message dated "Fri, 03 Sep 2021 15:00:00 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2498874.1630679973.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 03 Sep 2021 10:39:33 -0400
Message-ID: <2498875.1630679973@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2498875.1630679973%40sss.pgh.pa.us>
Precedence: bulk

"=3D?UTF-8?B?6JSh5qKm5aifKOeOiuS6jik=3D?=3D" <mengjuan.cmj@alibaba-inc.com=
> writes:
> I want to share a patch with you, in which I add a guc parameter 'enable=
_send_stop' to enable set the value of SendStop in postmaster.c more conve=
niently.  SendStop enable postmaster to send SIGSTOP rather than SIGQUIT t=
o its children when some backend dumps core, and this variable is original=
ly set with -T parameter when start postgres, which is inconvenient to con=
trol in some scenarios.

TBH, I'd sooner rip out SendStop, and simplify the related postmaster
logic.  I've never used it in twenty-some years of Postgres hacking,
and I doubt anyone else has used it much either.  It's not worth the
overhead of a GUC.  (The argument that you need it in situations
where you can't control the postmaster's command line seems pretty
thin, too.  I'm much more worried about somebody turning it on by
accident and then complaining that the cluster freezes upon crash.)

			regards, tom lane