Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fgwFJ-0005DI-Kz
	for pgsql-hackers@arkaria.postgresql.org; Sat, 21 Jul 2018 18:04:45 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fgwFF-00029K-J9
	for pgsql-hackers@arkaria.postgresql.org; Sat, 21 Jul 2018 18:04:41 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fgwFF-00029C-27
	for pgsql-hackers@lists.postgresql.org; Sat, 21 Jul 2018 18:04:41 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fgwF7-0006Dz-OA
	for pgsql-hackers@postgresql.org; Sat, 21 Jul 2018 18:04:39 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w6LI4J2f024993;
	Sat, 21 Jul 2018 14:04:19 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
cc: "Tels" <nospam-pg-abuse@bloodgate.com>,
        "Victor Wagner" <vitus@wagner.pp.ru>,
        "pgsql-hackers" <pgsql-hackers@postgresql.org>
Subject: Re: Non-portable shell code in pg_upgrade tap tests
In-reply-to: <d8j60181qpn.fsf@dalvik.ping.uio.no>
References: <20180720153820.69e9ae6c@fafnir.local.vm>
 <17833.1532096747@sss.pgh.pa.us> <20180720175508.07776219@fafnir.local.vm>
 <c96303c04c360bbedaa04f90f515745b.squirrel@sm.webmail.pair.com>
 <4263.1532186967@sss.pgh.pa.us> <d8j60181qpn.fsf@dalvik.ping.uio.no>
Comments: In-reply-to ilmari@ilmari.org (Dagfinn Ilmari
 =?utf-8?Q?Manns=C3=A5ker?=)
	message dated "Sat, 21 Jul 2018 17:47:00 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24991.1532196259.1@sss.pgh.pa.us>
Date: Sat, 21 Jul 2018 14:04:19 -0400
Message-ID: <24992.1532196259@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> Hmm.  Yeah, probably.  I don't think this script is meant to be run with
>> arbitrary values of PGDATA, but most of the other uses are quoted, so
>> for consistency's sake this should be too.

> Attached is a patch fixing this.  I checked the rest of the script, and
> this seems to be the only place lacking quoting.

Done already, but thanks.

			regards, tom lane