Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: Correction to comment of brin_range_deserialize
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <CANWi6YMxXXbmDauRGYhZd-RSmM9vru3b3rOzVLC-noDJmbVbFA@mail.gmail.com>
Date: Thu, 29 Jan 2026 07:13:44 +0800
Cc: pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <24A6C2DC-CB0A-4073-9140-DAEB3C1EBEAE@gmail.com>
References: <CANWi6YMxXXbmDauRGYhZd-RSmM9vru3b3rOzVLC-noDJmbVbFA@mail.gmail.com>
To: ji xu <thanksgreed@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/24A6C2DC-CB0A-4073-9140-DAEB3C1EBEAE%40gmail.com>
Precedence: bulk


> On Jan 28, 2026, at 16:10, ji xu <thanksgreed@gmail.com> wrote:
>=20
> Hi Hackers,
>=20
> I found an issue in the comments of the  =
src/backend/access/brin/brin_minmax_multi.c file.
>=20
> The header comment of function brin_range_deserialize currently reads:
> "Serialize the in-memory representation into a compact varlena value."
>=20
> which looks like a copy/paste error, where "Serialize" should be =
"Deserialize".
>=20
> I'm posting this patch to fix the comment.
>=20
> Regards,
> ji xu
> <v1-0001-Correction-to-comment-of-brin_range_deserialize.patch>

Indeed, like a copy-pasto from the initial commit (ab59610) where the 2 =
functions (serialize/deserialize) were added.

The updated comment in the patch looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/