From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: Failure in commit_ts tap tests
To: Tom Lane <tgl@sss.pgh.pa.us>, Pavan Deolasee <pavan.deolasee@gmail.com>
References: 
 <CABOikdPhsHM+pX8skoEY1_T0OtKdO1udzUj4VCjU5VEt+bj4eA@mail.gmail.com>
 <19348.1484936537@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Message-ID: <24cf2b76-9b9f-bba9-7e8b-89b9d0ba2471@2ndQuadrant.com>
Date: Mon, 23 Jan 2017 08:28:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <19348.1484936537@sss.pgh.pa.us>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 01/20/2017 01:22 PM, Tom Lane wrote:
> Pavan Deolasee <pavan.deolasee@gmail.com> writes:
>> I'm surprised nobody reported this problem earlier.
> It looks like at least part of the answer is that the buildfarm isn't
> running this test.  AFAICS, it runs "make installcheck" not
> "make check" in src/test/modules.  I don't know whether any of the
> critters would have duplicated the failure, but they weren't trying.
>
> I don't know if any of the other src/test/modules/ subdirectories
> test more in make check mode than make installcheck mode, but if
> they do, we probably oughta change the buildfarm script.
>
> 			


Is there a reason why these tests aren't run under installcheck? If
there is a justification I can look at it, or we should decide on one
canonical mode of running the tests and stick to that.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers