Message-ID: <24e93efd-eeac-43a6-a75a-ad68eacb32ee@postgrespro.ru>
Date: Sun, 5 May 2024 09:45:47 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Subject: Re: Removing unneeded self joins
To: Robert Haas <robertmhaas@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Richard Guo <guofenglinux@gmail.com>,
 Alexander Lakhin <exclusion@gmail.com>,
 "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
 =?UTF-8?Q?Micha=C5=82_K=C5=82eczek?= <michal@kleczek.org>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <64486b0b-0404-e39e-322d-0801154901f3@postgrespro.ru>
 <CAPpHfdvJ3jBQaJQKrf69K++kXi+Tvzn6TXO-DKXj0KVJjvMebg@mail.gmail.com>
 <1bd80083-a13e-4e9f-a7ce-73c3faab521c@postgrespro.ru>
 <CAPpHfdsz8E085YF2VoJe2+h4YAShsh7p--t3kQfQTntiCy63Xg@mail.gmail.com>
 <922623af-872e-4cdc-9238-129b18bee42d@postgrespro.ru>
 <CAPpHfduoAHTp6O7Q8PDe_w=30v0n_06pGe5M65iR4DYcfaYnRw@mail.gmail.com>
 <0ed2cf02-e655-6ec7-a4fe-52fd8d572f65@gmail.com>
 <CAPpHfdsHWbdPVzUdmoKv3dpo8RHJOa=LQR-ZAT+89uvktMs9XA@mail.gmail.com>
 <735b5cd4-568d-fbf7-ad8c-dcfb4c3af86e@gmail.com>
 <CAPpHfdssga9CBQQ6s32t1Xb2Js2WuPfiporbAse334CJiyBb1Q@mail.gmail.com>
 <CAPpHfdvGVcud2i00pEVH2_GS09c8UsDh6P-SEOLd6YMGOxiNEw@mail.gmail.com>
 <CAMbWs49Q8g1LPVCeNHYv-Y-gFo826ertrg6nYNC9LL=8=zHP3g@mail.gmail.com>
 <CAPpHfdsUiwbGLbBwtdL+UCT5GCUVEU+SqQaaZjtcje3znU2JgQ@mail.gmail.com>
 <2422119.1714691974@sss.pgh.pa.us>
 <CAPpHfdv6B8HCLdj8WidBryRrX0+X3F1rrR8uAuMQmp6rvPdscg@mail.gmail.com>
 <CA+TgmoYSRwjeTDeLY+OfMkKZOg0M6bBOh-L9UfZExu0xZVY_bA@mail.gmail.com>
Content-Language: en-US
Organization: Postgres Professional
In-Reply-To: 
 <CA+TgmoYSRwjeTDeLY+OfMkKZOg0M6bBOh-L9UfZExu0xZVY_bA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/24e93efd-eeac-43a6-a75a-ad68eacb32ee%40postgrespro.ru>
Precedence: bulk

On 3/5/2024 20:55, Robert Haas wrote:
> One of my most embarrassing gaffes in this area personally was
> a448e49bcbe40fb72e1ed85af910dd216d45bad8. I don't know how I managed
> to commit the original patch without realizing it was going to cause
> an increase in the WAL size, but I can tell you that when I realized
> it, my heart sank through the floor.
I discovered this feature and agree that it looks like a severe problem.
Unfortunately, in the case of the SJE patch, the committer and reviewers 
don't provide negative feedback. We see the only (I'm not sure I use the 
proper English phrase) 'negative feelings' from people who haven't 
reviewed or analysed it at all (at least, they didn't mention it).

Considering the situation, I suggest setting the default value of 
enable_self_join_removal to false in PG17 for added safety and then 
changing it to true in early PG18.

Having no objective negative feedback, we have no reason to change 
anything in the design or any part of the code. It looks regrettable and 
unusual.

After designing the feature, fixing its bugs, and reviewing joint 
patches on the commitfest, the question more likely lies in the planner 
design. For example, I wonder if anyone here knows why exactly the 
optimiser makes a copy of the whole query subtree in some places. 
Another example is PlannerInfo. Can we really control all the 
consequences of introducing, let's say, a new JoinDomain entity?

You also mentioned 2024.pgconf.dev. Considering the current migration 
policy in some countries, it would be better to work through the online 
presence as equivalent to offline. Without an online part of the 
conference, the only way to communicate and discuss is through this 
mailing list.

-- 
regards,
Andrei Lepikhov