From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        Mark Wong <mark@2ndquadrant.com>,
 Justin Pryzby <pryzby@telsasoft.com>,
        Andres Freund <andres@anarazel.de>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: stress test for parallel workers
In-reply-to: <17884.1570915552@sss.pgh.pa.us>
References: <20190723162703.GM22387@telsasoft.com>
 <6762.1563902927@sss.pgh.pa.us> <20190723174222.GO22387@telsasoft.com>
 <CA+hUKGLch1bNWdG-G8YaeJbyVsper6hG86Ugx9tSWG3=a1R89Q@mail.gmail.com>
 <32179.1563919918@sss.pgh.pa.us>
 <CA+hUKGKZS32Lx1zViq0W8omCjHjBsN=dJZ8nX-rkhv1W=b802Q@mail.gmail.com>
 <17389.1563945314@sss.pgh.pa.us>
 <CA+hUKGL6cDyb2maq2P60cEsjFK=3saBCAj7sDzE3jysL-PRwqg@mail.gmail.com>
 <31032.1565152159@sss.pgh.pa.us>
 <CA+hUKGJNS6gZ=w=+wxjqhmck-voJ7FBuejHnw8mQgAp2yt0A9g@mail.gmail.com>
 <18537.1570421268@sss.pgh.pa.us> <5350.1570743291@sss.pgh.pa.us>
 <84813a30-8c34-9c32-7ad5-90d9eefba468@2ndQuadrant.com>
 <06d6be5a-7af2-ef78-0abc-6bfe500ead87@2ndQuadrant.com>
 <20032.1570808731@sss.pgh.pa.us> <14878.1570820201@sss.pgh.pa.us>
 <CA+hUKGKNgufn12Uh4iEh5y=JkEnUBWnLLmi8L4zwzMunFeKwSA@mail.gmail.com>
 <18266.1570824826@sss.pgh.pa.us> <21051.1570828384@sss.pgh.pa.us>
 <17884.1570915552@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sat, 12 Oct 2019 17:25:52 -0400"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <24942.1570925055.0@sss.pgh.pa.us>
Date: Sat, 12 Oct 2019 20:06:32 -0400
Message-ID: <25033.1570925192@sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24942.1570925055.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable

I wrote:
> In short, my current belief is that Linux PPC64 fails when trying
> to deliver a signal if there's right around 2KB of stack remaining,
> even though it should be able to expand the stack and press on.

I figured I should try to remove some variables from the equation
by demonstrating this claim without involving Postgres.  The attached
test program eats some stack space and then waits to be sent SIGUSR1.
For some values of "some stack space", it dumps core:

[tgl@postgresql-fedora ~]$ gcc -g -Wall -O1 stacktest.c
[tgl@postgresql-fedora ~]$ ./a.out 1240000 &
[1] 11796
[tgl@postgresql-fedora ~]$ kill -USR1 11796
[tgl@postgresql-fedora ~]$ signal delivered, stack base 0x7fffdc160000 top=
 0x7fffdc031420 (1240032 used)

[1]+  Done                    ./a.out 1240000
[tgl@postgresql-fedora ~]$ ./a.out 1242000 &
[1] 11797
[tgl@postgresql-fedora ~]$ kill -USR1 11797
[tgl@postgresql-fedora ~]$ =

[1]+  Segmentation fault      (core dumped) ./a.out 1242000
[tgl@postgresql-fedora ~]$ uname -a
Linux postgresql-fedora.novalocal 4.18.19-100.fc27.ppc64le #1 SMP Wed Nov =
14 21:53:32 UTC 2018 ppc64le ppc64le ppc64le GNU/Linux

I don't think any further proof is required that this is
a kernel bug.  Where would be a good place to file it?

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-c; name="stacktest.c"; charset="us-ascii"
Content-ID: <24942.1570925055.2@sss.pgh.pa.us>
Content-Description: stacktest.c

#include <stdio.h>
#include <stdlib.h>
#include <signal.h>
#include <unistd.h>

static char *stack_base_ptr;
static char *stack_top_ptr;

static volatile sig_atomic_t sig_occurred = 0;

static void
sigusr1_handler(int signal_arg)
{
	sig_occurred = 1;
}

static void
consume_stack(long stackdepth)
{
	char		stack_cur;

	if ((stack_base_ptr - &stack_cur) < stackdepth)
		consume_stack(stackdepth);
	else
	{
		stack_top_ptr = &stack_cur;
		while (!sig_occurred)
			;
	}
}

int
main(int argc, char **argv)
{
	long		stackdepth = atol(argv[1]);
	char		stack_base;
	struct sigaction act;

	act.sa_handler = sigusr1_handler;
	sigemptyset(&act.sa_mask);
	act.sa_flags = 0;
	if (sigaction(SIGUSR1, &act, NULL) < 0)
		perror("sigaction");

	stack_base_ptr = (char *) (((size_t) &stack_base + 65535) & ~65535UL);

	consume_stack(stackdepth);

	if (sig_occurred)
		printf("signal delivered, stack base %p top %p (%zu used)\n",
			   stack_base_ptr, stack_top_ptr, stack_base_ptr - stack_top_ptr);
	else
		printf("no signal delivered\n");

	return 0;
}

------- =_aaaaaaaaaa0--