public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: pgsql: Harden new test case against force_parallel_mode = regress.
Date: Fri, 03 Mar 2023 12:46:42 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmobbA4gC103oSaFw+M7-ivmOMXRLAEx3Lwk+2asB92=4sg@mail.gmail.com>
References: <[email protected]>
	<CA+TgmoY-dsB-6GyF8q+V0T5+0Gbw0cT6TE7_8SsnESeUHZpnZQ@mail.gmail.com>
	<[email protected]>
	<CA+TgmobbA4gC103oSaFw+M7-ivmOMXRLAEx3Lwk+2asB92=4sg@mail.gmail.com>

Robert Haas <[email protected]> writes:
> On Fri, Mar 3, 2023 at 11:37 AM Tom Lane <[email protected]> wrote:
>> +ERROR:  role "regress_psql_user" does not exist
>> +CONTEXT:  while setting parameter "session_authorization" to "regress_psql_user"

> Oh, that's interesting (and sad). A parallel worker has a "startup
> transaction" that is used to restore library and GUC state, and then
> after that transaction commits, it starts up a new transaction that
> uses the same snapshot and settings as the transaction in the parallel
> leader. So the problem here is that the startup transaction can't see
> the uncommitted work of some unrelated (as far as it knows)
> transaction, and that prevents restoring the session_authorization
> GUC.

Got it.

> That startup transaction has broken stuff before, and it would be nice
> to get rid of it. Unfortunately, I don't remember right now why we
> need it in the first place. I'm fairly sure that if you load the
> library and GUC state without any transaction, that doesn't work,
> because a bunch of important processing gets skipped. And I think if
> you try to do those things in the "real" transaction that fails for
> some reason too, maybe that there's no guarantee that all the relevant
> GUCs can be changed at that point, but I'm fuzzy on the details at the
> moment.

Couldn't we install the leader's snapshot into both transactions?

			regards, tom lane

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Harden new test case against force_parallel_mode = regress.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox