Feedback-ID: i7c334307:Fastmail
From: "David E. Wheeler" <david@justatheory.com>
Message-Id: <25075595-41F1-4BDA-9390-9E0D983BA909@justatheory.com>
Content-Type: multipart/signed;
	boundary="Apple-Mail=_98C34C54-42AC-4F1F-A6FB-ADEACD5C0397";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\))
Subject: Re: RFC: Additional Directory for Extensions
Date: Thu, 24 Apr 2025 18:59:12 -0400
In-Reply-To: <6B5BF07B-8A21-48E3-858C-1DC22F3A28B4@justatheory.com>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>,
 Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>,
 Craig Ringer <craig.ringer@enterprisedb.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
To: Peter Eisentraut <peter@eisentraut.org>
References: <CA+TgmoaMk==vOUmWwJ5ZA-EueNqa9RQaWMEiHCF1ZKW_YCcj8g@mail.gmail.com>
 <AF4A50CD-C5CF-406D-9700-1B889F40E8FB@justatheory.com>
 <CAGRY4nx8Fmea4udk--PKdvfgpNdqC+rcueAmGwuw2PD9dv+zqQ@mail.gmail.com>
 <D30A91FA-A6D4-4737-941F-0BBB2984B730@justatheory.com>
 <0d384836-7e6e-4932-af3b-8dad1f6fee43@eisentraut.org>
 <4f7209ba-1ca2-475e-9a70-0f3fe0be6378@eisentraut.org>
 <CAFY6G8dzuLXFjONX5E-TvyD5E9r21b5vp1My_nMcqdGD0VYfYw@mail.gmail.com>
 <12312928-5516-49b8-81c1-a7b56fd01bc8@dunslane.net>
 <CAFY6G8dGcv1D8tCkjrz+9DvAYG9h4U=hBm0VXjJEXExy44hauQ@mail.gmail.com>
 <CAFY6G8eOMkGXLqzUz=qXrwt4X_HvmVZ13570DAbgAiw+3q03DA@mail.gmail.com>
 <CAFY6G8fV5FTqn7p8pxbvPYUD5+ffik-J50GChjKH2Gg7d=fRPg@mail.gmail.com>
 <38c53446-6b65-4222-b76b-351e56f4841c@eisentraut.org>
 <CAFY6G8cGeUV0f5K8v-Du0ts3iZyRE6Q5dNtYjQq8cjS4epLX5A@mail.gmail.com>
 <7c178ff3-20a5-493e-a704-e6b3263e782f@eisentraut.org>
 <CAFY6G8d56BK5TZ7K+uw4DHLZ=9Th3p+E1x4pp26nJ_K5k4EUwA@mail.gmail.com>
 <28e98657-9369-4539-9e06-9124d1e77853@eisentraut.org>
 <6B5BF07B-8A21-48E3-858C-1DC22F3A28B4@justatheory.com>
Archived-At: <https://www.postgresql.org/message-id/25075595-41F1-4BDA-9390-9E0D983BA909%40justatheory.com>
Precedence: bulk


--Apple-Mail=_98C34C54-42AC-4F1F-A6FB-ADEACD5C0397
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_848664FB-FAA3-4615-AE3F-1BA482F524AF"


--Apple-Mail=_848664FB-FAA3-4615-AE3F-1BA482F524AF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On Mar 19, 2025, at 13:29, David E. Wheeler <david@justatheory.com> =
wrote:

> I think this should at least be documented, but generally feels =
unexpected to me. I=E2=80=99ve attached a patch that fleshes out the =
docs, along with an example of setting `extension_control_path` and =
`dynamic_library_path` to use the locations. It might not have the =
information right about the need for =E2=80=9Cpostgresql=E2=80=9D or =
=E2=80=9Cpgsql=E2=80=9D in the path. Back in 2003[1] it was just =
=E2=80=9Cpostgres=E2=80=9D, but I couldn=E2=80=99t find the logic for it =
just now.

Here=E2=80=99s a rebase.

Best,

David


--Apple-Mail=_848664FB-FAA3-4615-AE3F-1BA482F524AF
Content-Disposition: attachment;
	filename=v2-0001-Flesh-out-docs-for-the-prefix-make-variable.patch
Content-Type: application/octet-stream;
	name=v2-0001-Flesh-out-docs-for-the-prefix-make-variable.patch;
	x-unix-mode=0644
Content-Transfer-Encoding: quoted-printable

=46rom=20448a03ac53fd145eb5da63c96ac99a99876de642=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20"David=20E.=20Wheeler"=20=
<david@justatheory.com>=0ADate:=20Thu,=2024=20Apr=202025=2018:57:26=20=
-0400=0ASubject:=20[PATCH=20v2]=20Flesh=20out=20docs=20for=20the=20=
`prefix`=20make=20variable=0A=0AThe=20variable=20is=20a=20bit=20magical=20=
in=20how=20it=20requires=20"postgresql"=20or=20"pgsql"=0Ato=20be=20part=20=
of=20the=20path,=20and=20files=20end=20up=20in=20its=20`share`=20and=20=
`lib`=0Asubdirectories.=20So=20mention=20all=20that=20and=20show=20an=20=
example=20of=20setting=0A`extension_control_path`=20and=20=
`dynamic_library_path`=20to=20use=20those=0Alocations.=0A---=0A=20=
doc/src/sgml/extend.sgml=20|=2033=20+++++++++++++++++++++++++++++----=0A=20=
1=20file=20changed,=2029=20insertions(+),=204=20deletions(-)=0A=0Adiff=20=
--git=20a/doc/src/sgml/extend.sgml=20b/doc/src/sgml/extend.sgml=0Aindex=20=
64f8e133cae..4e75a01fae4=20100644=0A---=20a/doc/src/sgml/extend.sgml=0A=
+++=20b/doc/src/sgml/extend.sgml=0A@@=20-1809,10=20+1809,35=20@@=20=
include=20$(PGXS)=0A=20=20=20=20=20setting=20=
<varname>PG_CONFIG</varname>=20to=20point=20to=20its=0A=20=20=20=20=20=
<command>pg_config</command>=20program,=20either=20within=20the=20=
makefile=0A=20=20=20=20=20or=20on=20the=20<literal>make</literal>=20=
command=20line.=0A-=20=20=20=20You=20can=20also=20select=20a=20separate=20=
installation=20directory=20for=20your=20extension=0A-=20=20=20=20by=20=
setting=20the=20<literal>make</literal>=20variable=20=
<varname>prefix</varname>=0A-=20=20=20=20on=20the=20=
<literal>make</literal>=20command=20line.=20=20(But=20this=20will=20then=20=
require=0A-=20=20=20=20additional=20setup=20to=20get=20the=20server=20to=20=
find=20the=20extension=20there.)=0A+=20=20=20</para>=0A+=0A+=20=20=20=
<para>=0A+=20=20=20=20You=20can=20also=20select=20a=20separate=20=
directory=20prefix=20in=20which=20to=20install=20your=0A+=20=20=20=20=
extension's=20files=20by=20setting=20the=20<literal>make</literal>=20=
variable=0A+=20=20=20=20<varname>prefix</varname>=20when=20executing=20=
<literal>make=20install</literal>=0A+=20=20=20=20like=20so:=0A=
+<programlisting>=0A+make=20install=20prefix=3D/etc/postgresql=0A=
+</programlisting>=0A+=20=20=20=20This=20will=20install=20the=20control=20=
SQL=20files=20into=0A+=20=20=20=20=
<literal>/etc/postgresql/share</literal>=20and=20shared=20modules=20into=0A=
+=20=20=20=20<literal>/etc/postgresql/lib</literal>.=20If=20the=20prefix=20=
does=20not=0A+=20=20=20=20include=20the=20strings=20=
<literal>postgresql</literal>=20or=0A+=20=20=20=20=
<literal>pgsql</literal>,=20such=20as:=0A+<programlisting>=0A+make=20=
install=20prefix=3D/etc/extras=0A+</programlisting>=0A+=20=20=20=20Then=20=
the=20<literal>postgresql</literal>=20directory=20will=20be=20appended=20=
io=20the=0A+=20=20=20=20prefix,=20installing=20the=20control=20SQL=20=
files=20into=0A+=20=20=20=20=
<literal>/etc/extras/postgresql/share</literal>=20and=20shared=20modules=20=
into=0A+=20=20=20=20<literal>/etc/extras/postgresql/lib</literal>.=20=
Either=20way,=20you'll=20need=20to=0A+=20=20=20=20set=20<xref=20=
linkend=3D"guc-extension-control-path"/>=20and=20<xref=0A+=20=20=20=20=
linkend=3D"guc-dynamic-library-path"/>=20to=20allow=0A+=20=20=20=20=
<productname>PostgreSQL</productname>=20to=20find=20the=20files:=0A=
+</programlisting>=0A+extension_control_path=20=3D=20=
'/etc/extras/postgresql/share/extension:$system'=0A+dynamic_library_path=20=
=3D=20'/etc/extras/postgresql/lib:$libdir'=0A+=20</programlisting>=0A=20=20=
=20=20</para>=0A=20=0A=20=20=20=20<para>=0A--=20=0A2.48.1=0A=0A=

--Apple-Mail=_848664FB-FAA3-4615-AE3F-1BA482F524AF--

--Apple-Mail=_98C34C54-42AC-4F1F-A6FB-ADEACD5C0397
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmgKwkAACgkQkt9idPjI
gfF02g//X9iX4Kmg7zkN5kKevKMG0b1RZIh47CWe+b7fXvrpwMebecoGIjLUvQj9
mhubbA5UBxdlqf4BOM/9L1w/4CK/u/VcpMLJX3jx44p8L1nbt2c6K5QnJM53vN3E
1mpqlK/biZjpGeKO977F0HFTMAN0OWFa0QUiSbVBWjMB3NXcauHFTXxVwbzJNpTr
/6E6uw8MVITLUqO7mgzRwOGJz+mU6Sv2LnjkQhBccs/wifDZ3bHMqp80eIDoPJR8
AJrV8o8/7rsY9De+2RHjX2H8daMPjlrLEQs/Bwv3ChaB1AAfuaT4o4ygM2taFomt
5/ZRADv2fThl67qWBSWUJJkaq7TNbl6gXc53uLozMMEGxN99QbniotoHzJnRV01+
uixYq7GmJNlCTR1L+pb7fkAduVjolzfrjP0e5IqsSIt3GUIcVWvXcpyzUbo2/d3I
GUprOXO+sGLpQdxVxWD143lKmDnjMZzcYqXUCIDocpBmyiWqdK0q2IYxB83KaJlO
fQvU/Uw0XPg+7Jb3yLz77iCg50xn9WSaw5qZ28ZwJpaoAXMk/ExxHEE2tj5tBalP
v1D0JPQUuL+pDbFTnZsprWOBPlUwVTNbFUPmWyCE9EYwda6zQUguXBt8xim7TNnV
2oUfjml3e6rYo5TInXJZkR6TT4cql660WJqnTfbnQNio4uNeY88=
=oT3Y
-----END PGP SIGNATURE-----

--Apple-Mail=_98C34C54-42AC-4F1F-A6FB-ADEACD5C0397--