From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: psql: Make SSL info display more compact
In-reply-to: <6E96453E-FD9E-4E04-A829-B7D5F6159279@yesql.se>
References: <aee28ee7-0ab3-c2e2-5bed-109feb0c089b@enterprisedb.com>
 <D0D58311-5C36-4B6C-9A09-8EC32A0D8A75@yesql.se>
 <87sfs3e04m.fsf@wibble.ilmari.org>
 <f59b3abc-3c42-c627-b7d6-dafd93ac68d9@enterprisedb.com>
 <6E96453E-FD9E-4E04-A829-B7D5F6159279@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Mon, 28 Feb 2022 13:48:43 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2510881.1646061162.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 28 Feb 2022 10:12:42 -0500
Message-ID: <2510882.1646061162@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2510882.1646061162%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> On 28 Feb 2022, at 12:56, Peter Eisentraut <peter.eisentraut@enterprised=
b.com> wrote:
>> On 28.02.22 11:50, Dagfinn Ilmari Manns=C3=A5ker wrote:
>>> How about making it show "compression: on" if compression is on, but
>>> nothing in the common "off" case?

>> That would work for me.

> On POLA grounds I would prefer to never to show it.  If we ever get libp=
q
> compression and want to show that, I'd prefer that we didn't end up
> "compression" meaning one thing except when it means two things.

Well, any such output would presumably be on a different line and
thus distinguishable from the SSL property; plus, it'd be impossible
for both forms to show up in the same connection.

However, how about writing "SSL compression: on" versus writing
nothing?  That avoids doubt about what it means.  I don't buy
Michael's argument that this is ambiguous, either.

			regards, tom lane