From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
cc: Noah Misch <noah@leadboat.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fixing WAL instability in various TAP tests
In-reply-to: <2B4C64CF-EE3F-474B-9685-6A927E5E49AE@enterprisedb.com>
References: <32A1FDD1-9C7B-43B1-B3EE-49198DD3F887@enterprisedb.com>
 <20210925052151.GA4082552@rfd.leadboat.com>
 <2E9D28A3-1B54-446B-AC12-3BF86A2B522A@enterprisedb.com>
 <2502590.1632579467@sss.pgh.pa.us>
 <2B4C64CF-EE3F-474B-9685-6A927E5E49AE@enterprisedb.com>
Comments: In-reply-to Mark Dilger <mark.dilger@enterprisedb.com>
	message dated "Sat, 25 Sep 2021 08:20:06 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2515243.1632584596.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 25 Sep 2021 11:43:16 -0400
Message-ID: <2515244.1632584596@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2515244.1632584596%40sss.pgh.pa.us>
Precedence: bulk

Mark Dilger <mark.dilger@enterprisedb.com> writes:
> You may be right, but the conversation about "all possible settings" was=
 started by Noah.  I was really just talking about tests that depend on wa=
l files not being removed, but taking no action to guarantee that, merely =
trusting that under default settings they won't be.  I can't square that d=
esign against other TAP tests that do take measures to prevent wal files b=
eing removed.  Why is the precaution taken in some tests but not others?

If we are doing something about that in some test cases, I'd agree with
doing the same thing in others that need it.  It seems more likely to
be an oversight than an intentional test condition.

			regards, tom lane