Feedback-ID: ie0a040ee:Fastmail
Message-ID: <2515f85a-217c-416e-b87e-7c480c4e1c5b@eisentraut.org>
Date: Wed, 8 Apr 2026 14:51:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
To: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
 Dave Cramer <davecramer@postgres.rocks>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <aa73q1aT0A3/vke/@ip-10-97-1-34.eu-west-3.compute.internal>
 <44885d54-0376-46b3-b574-59e0e3098580@eisentraut.org>
 <dfb1373e-258f-42b7-ac76-0f5858936dfa@eisentraut.org>
 <4ab608af-2f90-47d8-88a5-6329f6630fff@eisentraut.org>
 <acI6X6YmtHnEURKL@ip-10-97-1-34.eu-west-3.compute.internal>
 <ff1b26a3-7f36-474a-93f1-bb9afcc7cf87@eisentraut.org>
 <1912638.1775510391@sss.pgh.pa.us>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <1912638.1775510391@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/2515f85a-217c-416e-b87e-7c480c4e1c5b%40eisentraut.org>
Precedence: bulk

On 06.04.26 23:19, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> The first three patches have been committed.
> 
> b4a132022 has had some not-so-desirable effects in the buildfarm:
> drongo and hoatzin are each spewing a couple dozen repetitive
> warnings about every bison-generated header file, eg
> 
> src/backend/bootstrap/bootparse.h(111): warning C4255: 'boot_yyparse': no function prototype given: converting '()' to '(void)'
> 
> Both of those machines are using bison 2.7, which is pretty old
> and evidently isn't careful about generating complete prototypes.
> 
> I'm not sure if there's anything to be done about this, except
> perhaps nag the animals' owners to find a newer bison somewhere.
> We could revert b4a132022, but then we might miss valid warnings
> about such issues in Windows-only code.

Let's try the nagging route.

I found it especially curious that hoatzin is a relatively new member, 
so why is it running this ancient Bison version?  Looking at the 
Chocolatey packages:

https://community.chocolatey.org/packages?q=bison

it appears that

     choco install winflexbison

gives you the old version, and you need

     choco install winflexbison3

to get a newer version.  So it seems easy to fall into that "trap" if 
you don't pay attention.

So perhaps these buildfarm members could update their Bison version 
sometime.

I found one mention of this command in our wiki 
(https://wiki.postgresql.org/wiki/Meson#Windows), which I updated.  If 
we find any other documents or guides with these commands, we should try 
to get them updated, too.