Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rfSKv-000Fhk-24
	for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Feb 2024 22:23:37 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rfSKt-00Fcfj-B9
	for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Feb 2024 22:23:35 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rfSKt-00Fcfa-1p
	for pgsql-hackers@lists.postgresql.org; Wed, 28 Feb 2024 22:23:35 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rfSKp-001uzM-PS
	for pgsql-hackers@postgresql.org; Wed, 28 Feb 2024 22:23:34 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 41SMNMjM2520882;
	Wed, 28 Feb 2024 17:23:22 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: Andres Freund <andres@anarazel.de>, Thomas Munro <thomas.munro@gmail.com>,
        Noah Misch <noah@leadboat.com>, Michael Paquier <michael@paquier.xyz>,
        Robert Haas <robertmhaas@gmail.com>,
        Peter Smith <smithpb2250@gmail.com>, vignesh C <vignesh21@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Melanie Plageman <melanieplageman@gmail.com>
Subject: Re: Relation bulk write facility
In-reply-to: <07b5f917-f07a-4878-8c01-be491948da24@iki.fi>
References: <20240224212936.f3zcbs24f7oaapm4@alap3.anarazel.de> <0C469A7A-548C-4B0C-9495-730FE80046E1@iki.fi> <CA+hUKGLAr9Rki58cNCdv_ivR5=Uyps5v-e-bEhHUK3gJTT7wtQ@mail.gmail.com> <CA+hUKGLuG2s4-+4DH+JDJh0CiSGU8SbGfK1ZXYWkMQS7iHdGxw@mail.gmail.com> <31db8d41-2ac9-4b5e-b7a8-712d6d7d7aa2@iki.fi> <20240225194322.a5@rfd.leadboat.com> <1535845.1708890691@sss.pgh.pa.us> <CA+Tgmoaoi6BioWTndnkRmMVxQ4QL=xF7Z_PC_8zwpreNshfnJQ@mail.gmail.com> <ZdwRK-bqyRt4khc6@paquier.xyz> <3a0d22fa-7613-4881-aa19-ddd31fb92cc0@iki.fi> <20240228092642.i23w4qzdsuy6da6y@alap3.anarazel.de> <fabc53d3-aee9-4474-921a-cac66dc2e6db@iki.fi> <2311406.1709136283@sss.pgh.pa.us> <07b5f917-f07a-4878-8c01-be491948da24@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Wed, 28 Feb 2024 23:47:33 +0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2520880.1709159002.1@sss.pgh.pa.us>
Date: Wed, 28 Feb 2024 17:23:22 -0500
Message-ID: <2520881.1709159002@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2520881.1709159002%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 28/02/2024 18:04, Tom Lane wrote:
>> The commit that added that test added a support function
>> "get_columns_length" which is now unused.  Should we get rid of that
>> as well?

> I see you just removed it; thanks!

In the no-good-deed-goes-unpunished department: crake is reporting
that this broke our cross-version upgrade tests.  I'll go fix that.

			regards, tom lane