From: Tom Lane <tgl@sss.pgh.pa.us>
To: Glen Knowles <gknowles@ieee.org>
cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: _WINSOCK_DEPRECATED_NO_WARNINGS
In-reply-to: 
 <CAJCH0yD6bP_qGxawjawWNCJdrL1ncg-Yfey7TCYWfsFTYvdBbA@mail.gmail.com>
References: <20124.1510850225@sss.pgh.pa.us>
 <CAJCH0yD6bP_qGxawjawWNCJdrL1ncg-Yfey7TCYWfsFTYvdBbA@mail.gmail.com>
Comments: In-reply-to Glen Knowles <gknowles@ieee.org>
	message dated "Thu, 16 Nov 2017 19:28:19 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <25236.1510890415.1@sss.pgh.pa.us>
Date: Thu, 16 Nov 2017 22:46:55 -0500
Message-ID: <25237.1510890415@sss.pgh.pa.us>
Precedence: bulk

Glen Knowles <gknowles@ieee.org> writes:
> On Thu, Nov 16, 2017 at 8:37 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> but evidently it chose the wrong cutoff for when to enable that
>> symbol, because woodlouse is (or claims to be) running VS2013.

> It's actually checking the wrong thing, the problem is the version of the
> Windows SDK, and while the one installed by default with VS2015 might be
> the right place to cutoff it's not uncommon to have multiple versions of
> the SDK (and VS) in various combinations.

Ah, interesting point --- though it's not clear that woodlouse is actually
running a mixture of SDK/VS releases.

> Or you could just define it unconditionally. :)

Already done that way.

I wonder though if this means the other tests of _MSC_VER in our tree
are wrong?

			regards, tom lane