Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzNAb-0003SU-TU for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Dec 2021 18:13:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mzNAa-0000Yz-5p for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Dec 2021 18:13:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzNAZ-0000Yp-TI for pgsql-hackers@lists.postgresql.org; Mon, 20 Dec 2021 18:13:55 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzNAX-00051w-Na for pgsql-hackers@lists.postgresql.org; Mon, 20 Dec 2021 18:13:54 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1BKIDp9Z2524669; Mon, 20 Dec 2021 13:13:51 -0500 From: Tom Lane To: Robert Haas cc: Justin Pryzby , PostgreSQL Hackers Subject: Re: sqlsmith: ERROR: XX000: bogus varno: 2 In-reply-to: References: <20211219205422.GT17618@telsasoft.com> <2209221.1639948636@sss.pgh.pa.us> <2445883.1640017555@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Mon, 20 Dec 2021 13:00:12 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2524667.1640024031.1@sss.pgh.pa.us> Date: Mon, 20 Dec 2021 13:13:51 -0500 Message-ID: <2524668.1640024031@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > The commit that added PartitionBoundSpec and PartitionRangeDatum was > committed by me and authored by Amit Langote. It is the original table > partitioning commit -- f0e44751d7175fa3394da2c8f85e3ceb3cdbfe63. I'm > reasonably sure that the reason why those didn't get added to > expression_tree_walker is that they don't seem like something that can > ever appear in an expression. I still don't understand why that's not > true. The reason the regression tests fail if I only patch ruleutils is that psql \d on a partitioned table invokes ... pg_get_expr(c.relpartbound, c.oid) FROM pg_catalog.pg_class c and evidently relpartbound does contain precisely these node types. regards, tom lane