From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Subject: Re: Back-branch bugs with fully-prunable UPDATEs
In-reply-to: 
 <CA+HiwqExk2yo57aX2Mj99nR0SOP4s43J1+nccLm6h=3UzoX0qQ@mail.gmail.com>
References: <20710.1554582479@sss.pgh.pa.us>
 <CA+HiwqExk2yo57aX2Mj99nR0SOP4s43J1+nccLm6h=3UzoX0qQ@mail.gmail.com>
Comments: In-reply-to Amit Langote <amitlangote09@gmail.com>
	message dated "Sun, 07 Apr 2019 16:54:19 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <25274.1554656265.1@sss.pgh.pa.us>
Date: Sun, 07 Apr 2019 12:57:45 -0400
Message-ID: <25275.1554656265@sss.pgh.pa.us>
Precedence: bulk

Amit Langote <amitlangote09@gmail.com> writes:
> On Sun, Apr 7, 2019 at 5:28 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This test script works fine in HEAD:
>> In v11, it suffers an assertion failure in ExecSetupPartitionTupleRouting.
>> In v10, it doesn't crash, but we do get
>> WARNING:  relcache reference leak: relation "parttbl" not closed

> What we did in the following commit is behind this:
> commit 58947fbd56d1481a86a03087c81f728fdf0be866
> Before this commit, partitioning related code in the executor could
> always rely on the fact that ModifyTableState.resultRelInfo[] only
> contains *leaf* partitions.  As of this commit, it may contain the
> root partitioned table in some cases, which breaks that assumption.

Ah.  Thanks for the diagnosis and patches; pushed.

I chose to patch HEAD similarly to v11, even though no bug manifests
right now; it seems safer that way.  We should certainly have the
test case in HEAD, now that we realize there wasn't coverage for this.

			regards, tom lane