From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: Michael Paquier <michael@paquier.xyz>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Weird test mixup
In-reply-to: <9fc78855-bce0-463f-a045-892ee3e142f5@iki.fi>
References: <10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi>
 <2387221.1710454778@sss.pgh.pa.us> <ZfOABU4ahF2QZQ6N@paquier.xyz>
 <2393552.1710458033@sss.pgh.pa.us>
 <44f5bf13-b46e-4b87-84de-2ac70fddbda0@iki.fi>
 <8e4cf596-dd70-432e-9068-16466ed596ed@iki.fi>
 <2498595.1710511222@sss.pgh.pa.us>
 <9fc78855-bce0-463f-a045-892ee3e142f5@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Fri, 15 Mar 2024 17:56:14 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2528844.1710527247.1@sss.pgh.pa.us>
Date: Fri, 15 Mar 2024 14:27:27 -0400
Message-ID: <2528845.1710527247@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2528845.1710527247%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 15/03/2024 16:00, Tom Lane wrote:
>> It may be even worse than it appears from the buildfarm status page.
>> My animals were stuck in infinite loops that required a manual "kill"
>> to get out of, and it's reasonable to assume there are others that
>> will require owner intervention.  Why would this test have done that,
>> if the module failed to load?

> The gin_incomplete_split test inserts rows until it hits the injection 
> point, at page split. There is a backstop, it should give up after 10000 
> iterations, but that was broken. Fixed that, thanks for the report!

Duh ...

> Hmm, don't we have any timeout that would kill tests if they get stuck?

AFAIK, the only constraint on a buildfarm animal's runtime is the
wait_timeout setting, which is infinite by default, and was on my
machines.  (Not anymore ;-).)  We do have timeouts in (most?) TAP
tests, but this wasn't a TAP test.

If this is a continuous-insertion loop, presumably it will run the
machine out of disk space eventually, which could be unpleasant
if there are other services running besides the buildfarm.
I think I'll go notify the buildfarm owners list to check for
trouble.

Are there limits on the runtime of CI or cfbot jobs?  Maybe
somebody should go check those systems.

			regards, tom lane