From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_basebackup's --gzip switch misbehaves
In-reply-to: <YyFflUQmFnGkFSes@paquier.xyz>
References: <1400032.1662217889@sss.pgh.pa.us> <YxQ1tIYF8hbrNO7q@paquier.xyz>
 <YyAtkOU/C/SD9qlL@paquier.xyz> <2402847.1663105127@sss.pgh.pa.us>
 <YyFflUQmFnGkFSes@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 14 Sep 2022 13:59:01 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2529393.1663132683.1@sss.pgh.pa.us>
Date: Wed, 14 Sep 2022 01:18:03 -0400
Message-ID: <2529394.1663132683@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2529394.1663132683%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> And so, I have spent a couple of hours torturing the patch, applying
> it after a few tweaks and CI runs:
> ...
> The buildfarm is green so I think that we are good.  I have closed the
> open item.

+1, thanks for taking care of that.

As far as my original complaint about mamba goes, I've not quite
been able to run it to ground.  However, I found that NetBSD
seems to be shipping unmodified zlib 1.2.11, which contains a
number of known bugs in deflate_stored() --- that is, the code
path implementing compression level 0.  Red Hat for one is
carrying several back-patched fixes in that part of zlib.
So for the moment I'm willing to write it off as "not our bug".
We aren't intentionally testing compression level 0, and hardly
anybody would intentionally use it in the field, so it's not
really a thing worth worrying about IMO.  But if mamba continues
to show failures in that test then it will be worth looking closer.

			regards, tom lane