From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>,
        Noah Misch <noah@leadboat.com>, Julien Rouhaud <rjuju123@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>,
        Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set
In-reply-to: <CA+hUKGJDZt0MRhVSaaO5DX8KLjWf9RPD4YcsnfTSRcRjzCoY1g@mail.gmail.com>
References: <3735235.1633232078@sss.pgh.pa.us> <20211214020824.azjrighbeucby5yc@alap3.anarazel.de> <YbgsLG0q4n9f0JBE@paquier.xyz> <20211214061449.ynrygtcddn3ujunn@alap3.anarazel.de> <YblJLJKUZYI4Pqbq@paquier.xyz> <Ybqpy4nS6bMq5Qud@paquier.xyz> <YdVS+X4SNXO93Oib@paquier.xyz> <Yd0uUcGyYJrEPshD@paquier.xyz> <20220115055239.6i5mp7ujtcpto2mg@jrouhaud> <YeYj4DU5qY/rtKXT@paquier.xyz> <20220213045041.qhbw3ue6xmojts6c@alap3.anarazel.de> <CA+hUKGJDZt0MRhVSaaO5DX8KLjWf9RPD4YcsnfTSRcRjzCoY1g@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Sun, 13 Feb 2022 18:07:30 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2529474.1644729219.1@sss.pgh.pa.us>
Date: Sun, 13 Feb 2022 00:13:39 -0500
Message-ID: <2529475.1644729219@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2529475.1644729219%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> I thought it was a goal that VPATH builds shouldn't pollute the source
> tree, but the Make macro prove_check is explicitly doing so by
> default.  Perhaps *that* should be fixed?

Indeed.  That seems broken by definition.

More generally, I thought we'd established a convention that
all files made by TAP tests should be put inside the tmp_check
directory, to simplify cleanup and .gitignore rules.  But in
a VPATH build, tmp_check ought to live in the build tree.

			regards, tom lane