Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M297270=pgsql-hackers-arkari@postgresql.org>)
	id 1asAx5-00031e-4j
	for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Apr 2016 15:19:03 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M297270=pgsql-hackers-arkari@postgresql.org>)
	id 1asAx4-0007VW-O0
	for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Apr 2016 15:19:02 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1asAx3-0007Us-MC
	for pgsql-hackers@postgresql.org; Mon, 18 Apr 2016 15:19:01 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1asAwz-0007Ts-KC
	for pgsql-hackers@postgresql.org; Mon, 18 Apr 2016 15:19:01 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id u3IFIrTA025312;
	Mon, 18 Apr 2016 11:18:53 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Aleksander Alekseev <a.alekseev@postgrespro.ru>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Should we remove unused code?
In-reply-to: <20160418180711.55ac82c0@fujitsu>
References: <20160418180711.55ac82c0@fujitsu>
Comments: In-reply-to Aleksander Alekseev <a.alekseev@postgrespro.ru>
	message dated "Mon, 18 Apr 2016 18:07:11 +0300"
Date: Mon, 18 Apr 2016 11:18:53 -0400
Message-ID: <25311.1460992733@sss.pgh.pa.us>
X-Pg-Spam-Score: -2.9 (--)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Aleksander Alekseev <a.alekseev@postgrespro.ru> writes:
> For instance there are two flags - HASH_SEGMENT and HASH_FFACTOR that
> are in fact never used (see attachment). I wonder whether we should
> keep code like this or not. 

> What do you think?

The fact that make check-world doesn't run any code that uses some
feature isn't a great argument for removing it.  Consider third-party
extensions, for starters.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers