Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7918-0002g3-Iv for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Jan 2022 04:44:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n7916-0003Gw-Ok for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Jan 2022 04:44:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7916-0003Gn-FR for pgsql-hackers@lists.postgresql.org; Tue, 11 Jan 2022 04:44:16 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7911-0003FA-0x for pgsql-hackers@postgresql.org; Tue, 11 Jan 2022 04:44:15 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 20B4i6Hn2533118; Mon, 10 Jan 2022 23:44:06 -0500 From: Tom Lane To: Andres Freund cc: Justin Pryzby , Laurenz Albe , pgsql-hackers@postgresql.org Subject: Re: Use -fvisibility=hidden for shared libraries In-reply-to: <20220111033133.k5cj63ywz64oxj4y@alap3.anarazel.de> References: <20211101020311.av6hphdl6xbjbuif@alap3.anarazel.de> <20211101054700.z3jzmc5lnxlad4y7@alap3.anarazel.de> <2499085.1641859296@sss.pgh.pa.us> <20220111031107.GU14051@telsasoft.com> <20220111033133.k5cj63ywz64oxj4y@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Mon, 10 Jan 2022 19:31:33 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2533116.1641876246.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 10 Jan 2022 23:44:06 -0500 Message-ID: <2533117.1641876246@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-01-10 21:11:07 -0600, Justin Pryzby wrote: >> Without the patch, it fails under windows like: > Ah, yea. It's about matching the declarations in ltree.h with the > PG_FUNCTION_INFO_V1() one. > What is bugging me is that I am fairly sure that my local compilers at s= ome > point complained about such mismatches on linux as well. But I can't rep= roduce > that right now :/ Ah, I wondered about that. I'd sort of expected warnings from mismatched declarations, but I didn't see any on Linux or macOS. regards, tom lane