Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nisiJ-0006gf-NM for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Apr 2022 07:00:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nisiI-0000SO-4a for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Apr 2022 07:00:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nisiH-0000SD-81 for pgsql-hackers@lists.postgresql.org; Mon, 25 Apr 2022 07:00:49 +0000 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nisi9-0001dx-Hh for pgsql-hackers@postgresql.org; Mon, 25 Apr 2022 07:00:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1650870041; x=1682406041; h=message-id:date:mime-version:to:cc:references:from: in-reply-to:content-transfer-encoding:subject; bh=7YQUPZojz0L+TyVipn85JmQk5xfd3TkSZ0jmqEBbFMA=; b=Q5buMWSq+Oa34wb/OBLkCMl+cBDFgfxk7VSWumYI/G/ue4rrkp5vtuhV uVBCY4ntI5vZkaOqBwmSfOaVbpbyhjM8Z2iAIetOhWTrpedpnAT9Dw7YT HUcahoc0eUKG+ih7domjaMwz1ejbSk9z6Oh24vcuYixJ2c2hmIVayp7tz w=; X-IronPort-AV: E=Sophos;i="5.90,287,1643673600"; d="scan'208";a="190679772" Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1d-10222bbc.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP; 25 Apr 2022 07:00:25 +0000 Received: from EX13D03EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1d-10222bbc.us-east-1.amazon.com (Postfix) with ESMTPS id 81A171A009A; Mon, 25 Apr 2022 07:00:23 +0000 (UTC) Received: from [192.168.20.179] (10.43.160.156) by EX13D03EUC003.ant.amazon.com (10.43.164.192) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Mon, 25 Apr 2022 07:00:20 +0000 Message-ID: <25391d51-691d-6f23-2065-17006fb272e8@amazon.com> Date: Mon, 25 Apr 2022 09:00:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: Michael Paquier , David Christensen CC: Matthias van de Meent , PostgreSQL-development References: From: "Drouvot, Bertrand" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.43.160.156] X-ClientProxiedBy: EX13D36UWB004.ant.amazon.com (10.43.161.49) To EX13D03EUC003.ant.amazon.com (10.43.164.192) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 4/25/22 8:11 AM, Michael Paquier wrote: > On Sat, Apr 23, 2022 at 01:43:36PM -0500, David Christensen wrote: >> Hi Matthias, great point. Enclosed is a revised version of the patch >> that adds the fork identifier to the end if it's a non-main fork. > Like Alvaro, I have seen cases where this would have been really > handy. So +1 from me, as well, to have more tooling like what you are > proposing. +1 on the idea. FWIW, there is an extension doing this [1] but having the feature included in pg_waldump would be great. Bertrand [1]: https://github.com/bdrouvot/pg_wal_fp_extract