From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@postgresql.org, Nazir Bilal Yavuz <byavuz81@gmail.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: meson PGXS compatibility
In-reply-to: <20221005200710.luvw5evhwf6clig6@awork3.anarazel.de>
References: <20221005200710.luvw5evhwf6clig6@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 05 Oct 2022 13:07:10 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2551485.1665001222.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 05 Oct 2022 16:20:22 -0400
Message-ID: <2551486.1665001222@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2551486.1665001222%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
>   On macOS we ran ranlib after installing a static library. This was add=
ed a
>   long time ago, in 58ad65ec2def. I cannot reproduce an issue in more re=
cent
>   macOS versions.

I agree that shouldn't be necessary anymore (and if it is, we'll find
out soon enough).

>   I'm on the fence about removing the "touch $@" from the rule building =
static
>   libs. That was added because of macos's ranlib not setting fine-graine=
d
>   timestamps. On a modern mac ar and ranlib are the same binary, and may=
be
>   that means that ar has the same issue? Both do set fine-grained
>   timestamps:

Please see the commit message for 826eff57c4c: the issue seems to arise
only with specific combinations of software, in particular with non-Apple
versions of "make" (although maybe later Apple builds have fixed make's
failure to read sub-second timestamps?).  That's a relatively recent hack,
and I'm very hesitant to conclude that we don't need it anymore just
because you failed to reproduce an issue locally.  It very possibly isn't
a problem in a meson build, though, depending on how much meson depends on
file timestamps.

			regards, tom lane