From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
cc: Andres Freund <andres@anarazel.de>,
        Masahiko Sawada <sawada.mshk@gmail.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        Stephen Frost <sfrost@snowman.net>,
        Michael Paquier <michael.paquier@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Reviewing freeze map code
In-reply-to: 
 <CAA4eK1K_-Q8KkFykNn0dAhs2=MM2=Sj6n7oz+HtTsdXgjZKGpg@mail.gmail.com>
References: 
 <CAA4eK1K0aPO4tedf4X0fA6xoVB87PW-Z8dFFY+8Fo2r+AwfFBw@mail.gmail.com>
 <CAD21AoBgYuA2RM6+fYpYU1HT=Po9bOFytO43uUtoUe00UyASfg@mail.gmail.com>
 <CAA4eK1LO-kVU2d+U4GPCXNTNpFZBGOBdttCTuE1+sK3DqnwCRQ@mail.gmail.com>
 <CAD21AoBKZbdhnxxSL41ZBcJSqCr7S9=ZnNcwR=w+qwvTNJp3oQ@mail.gmail.com>
 <CAD21AoAkqb4coXEui8MHpzApH7iyQMOpuVfnHDSun5pjJ4=rgQ@mail.gmail.com>
 <20160706220613.xdekbqvvqx6ubzj2@alap3.anarazel.de>
 <CAD21AoCQQ3aywTOuz7CbmiLEiAToua8UXc7Wf4N7aNbjqJLjtg@mail.gmail.com>
 <CAA4eK1LbEeyJkvZR7aad5vTpSpKNCG+hcckFUV1a6-_Y0w755A@mail.gmail.com>
 <CAD21AoAqXDbR0TwK42YLJsujK9HqA=pT9O_yRWmyq5WiW9GoaQ@mail.gmail.com>
 <20160714060607.klwgq2qr7egt3zrr@alap3.anarazel.de>
 <20160716013203.gni5x6jjnmjajvc6@alap3.anarazel.de>
 <CAA4eK1K_-Q8KkFykNn0dAhs2=MM2=Sj6n7oz+HtTsdXgjZKGpg@mail.gmail.com>
Comments: In-reply-to Amit Kapila <amit.kapila16@gmail.com>
	message dated "Sat, 16 Jul 2016 16:40:52 +0530"
Date: Sat, 16 Jul 2016 11:49:06 -0400
Message-ID: <25549.1468684146@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Sat, Jul 16, 2016 at 7:02 AM, Andres Freund <andres@anarazel.de> wrote:
>> I think we have two choices how to deal with that: First, we can add a
>> new flags variable to xl_heap_lock similar to
>> xl_heap_insert/update/... and bump page magic,

> +1 for going in this way.  This will keep us consistent with how clear
> the visibility info in other places like heap_xlog_update().

Yeah.  We've already forced a catversion bump for beta3, and I'm about
to go fix PG_CONTROL_VERSION as well, so there's basically no downside
to doing an xlog version bump as well.  At least, not if you can get it
in before Monday.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers