From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>, David Steele <david@pgmasters.net>,
        David Rowley <david.rowley@2ndquadrant.com>,
        Sergei Kornilov <sk@zsrv.org>,
        PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Stephen Frost <sfrost@snowman.net>,
        Ildar Musin <i.musin@postgrespro.ru>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
In-reply-to: <20190501162021.q7r5cys6uwdb5bsp@alap3.anarazel.de>
References: <694691552422467@myt1-06117f29c1ea.qloud-c.yandex.net>
 <CA+TgmoYYm_TPXoWgucr99RCZQpO84f6rjOYMk9GcRCv5zaaqsw@mail.gmail.com>
 <21516.1552489217@sss.pgh.pa.us>
 <CA+TgmoZWSLUjVcc9KBSVvbn=U5QRgW1O-MgUX0y5CnLZOA2qyQ@mail.gmail.com>
 <2815991552495610@myt1-4903e6646a45.qloud-c.yandex.net>
 <7254.1552496972@sss.pgh.pa.us>
 <CA+TgmoY3Gb9ZL8fHVvPyues8XgFoE=jz-Ry+739SYkczME3vhA@mail.gmail.com>
 <CAKJS1f85QHXBm51GFup6doYXfB56nAOVBuLkbHFYNm82619NjQ@mail.gmail.com>
 <ea99b258-6d9d-b37f-ce0a-f9d2d8d81fc1@pgmasters.net>
 <CA+Tgmob7rAo+Ahu8jgQxquEVj9kyjRxVrUKzMYSymg2cf2Nczg@mail.gmail.com>
 <20190501162021.q7r5cys6uwdb5bsp@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 01 May 2019 09:20:21 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <25569.1556728681.1@sss.pgh.pa.us>
Date: Wed, 01 May 2019 12:38:01 -0400
Message-ID: <25570.1556728681@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> There's still an open item "Debate INFO messages in ATTACH PARTITION and
> SET NOT NULL" for this thread.  Is there anything further to be done? Or
> are we content with this for v12?

IIRC, that's based on my complaint that these messages have no business
being INFO level.  I'm definitely not content with the current state.

I proposed that we didn't need those messages at all, which Robert pushed
back on, but I'd be willing to compromise by reducing them to NOTICE or
DEBUG level.

The actually intended use of INFO level is to mark messages that the user
actively asked for (via VERBOSE or some morally-equivalent option), which
is why that level has such high priority.  If we had something like a
VERBOSE option for ALTER TABLE, it'd make plenty of sense to follow
VACUUM's precedent:

	if (params->options & VACOPT_VERBOSE)
		elevel = INFO;
	else
		elevel = DEBUG2;

It seems a bit late to be inventing such a thing for v12 though.

In the meantime, I'm not very content with random subsets of
ALTER TABLE acting as if they have been granted permission
to be VERBOSE.  It's unfriendly, and it's inconsistent because
there are so many other expensive ALTER TABLE actions that don't
do this.

			regards, tom lane