Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmQPE-0006nm-65 for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Nov 2021 01:03:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mmQPD-0006hi-5o for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Nov 2021 01:03:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmQPC-0006hZ-Sn for pgsql-hackers@lists.postgresql.org; Mon, 15 Nov 2021 01:03:30 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmQPA-00072m-0k for pgsql-hackers@postgresql.org; Mon, 15 Nov 2021 01:03:30 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 1881D60793; Mon, 15 Nov 2021 10:03:22 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.3 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_70149703744b0bd2232394325097c327" Content-Transfer-Encoding: 7bit Date: Mon, 15 Nov 2021 10:03:22 +0900 From: Shinya Kato To: Daniel Gustafsson Cc: pgsql-hackers@postgresql.org Subject: Re: Emit a warning if the extension's GUC is set incorrectly In-Reply-To: <681A95E0-0CCA-4C66-A12B-CE0D8D5076D7@yesql.se> References: <524fa2c0a34f34b68fbfa90d0760d515@oss.nttdata.com> <681A95E0-0CCA-4C66-A12B-CE0D8D5076D7@yesql.se> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <25643eaa81a69416317e85c2fd7d4c0a@oss.nttdata.com> X-Sender: Shinya11.Kato@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_70149703744b0bd2232394325097c327 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2021-11-15 04:50, Daniel Gustafsson wrote: > Seems reasonable on a quick skim, commit da2c1b8a2 did a similar > roundup back > in 2009 but at the time most of these didn't exist (pg_trgm did but > didn't have > custom option back then). There is one additional callsite defining > custom > variables in src/pl/tcl/pltcl.c which probably should get this > treatment as > well, it would align it with the pl/perl counterpart. > > I'll have a closer look and test tomorrow. Thank you for the review! I have missed src/pl/tcl/pltcl.c, so I created the new patch. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --=_70149703744b0bd2232394325097c327 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=v2_Add_EmitWarningOnPlaceholderes.patch Content-Disposition: attachment; filename=v2_Add_EmitWarningOnPlaceholderes.patch; size=1714 ZGlmZiAtLWdpdCBhL2NvbnRyaWIvYXV0aF9kZWxheS9hdXRoX2RlbGF5LmMgYi9jb250cmliL2F1 dGhfZGVsYXkvYXV0aF9kZWxheS5jCmluZGV4IDU4MjBhYzMyOGQuLmQxMWRkMWU0MTYgMTAwNjQ0 Ci0tLSBhL2NvbnRyaWIvYXV0aF9kZWxheS9hdXRoX2RlbGF5LmMKKysrIGIvY29udHJpYi9hdXRo X2RlbGF5L2F1dGhfZGVsYXkuYwpAQCAtNjcsNiArNjcsOSBAQCBfUEdfaW5pdCh2b2lkKQogCQkJ CQkJCU5VTEwsCiAJCQkJCQkJTlVMTCwKIAkJCQkJCQlOVUxMKTsKKworCUVtaXRXYXJuaW5nc09u UGxhY2Vob2xkZXJzKCJhdXRoX2RlbGF5Iik7CisKIAkvKiBJbnN0YWxsIEhvb2tzICovCiAJb3Jp Z2luYWxfY2xpZW50X2F1dGhfaG9vayA9IENsaWVudEF1dGhlbnRpY2F0aW9uX2hvb2s7CiAJQ2xp ZW50QXV0aGVudGljYXRpb25faG9vayA9IGF1dGhfZGVsYXlfY2hlY2tzOwpkaWZmIC0tZ2l0IGEv Y29udHJpYi9wZ190cmdtL3RyZ21fb3AuYyBiL2NvbnRyaWIvcGdfdHJnbS90cmdtX29wLmMKaW5k ZXggZmIzODEzNWY3YS4uMDQwN2M3ZGQ2NCAxMDA2NDQKLS0tIGEvY29udHJpYi9wZ190cmdtL3Ry Z21fb3AuYworKysgYi9jb250cmliL3BnX3RyZ20vdHJnbV9vcC5jCkBAIC0xMDAsNiArMTAwLDgg QEAgX1BHX2luaXQodm9pZCkKIAkJCQkJCQkgTlVMTCwKIAkJCQkJCQkgTlVMTCwKIAkJCQkJCQkg TlVMTCk7CisKKwlFbWl0V2FybmluZ3NPblBsYWNlaG9sZGVycygicGdfdHJnbSIpOwogfQogCiAv KgpkaWZmIC0tZ2l0IGEvY29udHJpYi9wb3N0Z3Jlc19mZHcvb3B0aW9uLmMgYi9jb250cmliL3Bv c3RncmVzX2Zkdy9vcHRpb24uYwppbmRleCA0OGM3NDE3ZTZlLi4zNjU1NTM5OGVjIDEwMDY0NAot LS0gYS9jb250cmliL3Bvc3RncmVzX2Zkdy9vcHRpb24uYworKysgYi9jb250cmliL3Bvc3RncmVz X2Zkdy9vcHRpb24uYwpAQCAtNDY5LDQgKzQ2OSw2IEBAIF9QR19pbml0KHZvaWQpCiAJCQkJCQkJ ICAgTlVMTCwKIAkJCQkJCQkgICBOVUxMLAogCQkJCQkJCSAgIE5VTEwpOworCisJRW1pdFdhcm5p bmdzT25QbGFjZWhvbGRlcnMoInBvc3RncmVzX2ZkdyIpOwogfQpkaWZmIC0tZ2l0IGEvY29udHJp Yi9zZXBnc3FsL2hvb2tzLmMgYi9jb250cmliL3NlcGdzcWwvaG9va3MuYwppbmRleCAxOWEzZmZi N2ZmLi40NGEwOWMzNWE3IDEwMDY0NAotLS0gYS9jb250cmliL3NlcGdzcWwvaG9va3MuYworKysg Yi9jb250cmliL3NlcGdzcWwvaG9va3MuYwpAQCAtNDU1LDYgKzQ1NSw4IEBAIF9QR19pbml0KHZv aWQpCiAJCQkJCQkJIE5VTEwsCiAJCQkJCQkJIE5VTEwpOwogCisJRW1pdFdhcm5pbmdzT25QbGFj ZWhvbGRlcnMoInNlcGdzcWwiKTsKKwogCS8qIEluaXRpYWxpemUgdXNlcnNwYWNlIGFjY2VzcyB2 ZWN0b3IgY2FjaGUgKi8KIAlzZXBnc3FsX2F2Y19pbml0KCk7CiAKZGlmZiAtLWdpdCBhL3NyYy9w bC90Y2wvcGx0Y2wuYyBiL3NyYy9wbC90Y2wvcGx0Y2wuYwppbmRleCBlMTE4Mzc1NTlkLi4xMzg5 YWEwOTQzIDEwMDY0NAotLS0gYS9zcmMvcGwvdGNsL3BsdGNsLmMKKysrIGIvc3JjL3BsL3RjbC9w bHRjbC5jCkBAIC00NzQsNiArNDc0LDggQEAgX1BHX2luaXQodm9pZCkKIAkJCQkJCQkgICBQR0Nf U1VTRVQsIDAsCiAJCQkJCQkJICAgTlVMTCwgTlVMTCwgTlVMTCk7CiAKKwlFbWl0V2FybmluZ3NP blBsYWNlaG9sZGVycygicGx0Y2x1Iik7CisKIAlwbHRjbF9wbV9pbml0X2RvbmUgPSB0cnVlOwog fQogCg== --=_70149703744b0bd2232394325097c327--