Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwGve-0003bP-Fr for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Jun 2021 04:25:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lwGvd-0004Om-1q for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Jun 2021 04:25:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwGvc-0004IC-Q2 for pgsql-hackers@lists.postgresql.org; Thu, 24 Jun 2021 04:25:24 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwGva-0005bK-TU for pgsql-hackers@lists.postgresql.org; Thu, 24 Jun 2021 04:25:23 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 15O4PFpJ2569714; Thu, 24 Jun 2021 00:25:15 -0400 From: Tom Lane To: Amit Kapila cc: Tomas Vondra , Amit Langote , Dilip Kumar , osumi.takamichi@fujitsu.com, Alvaro Herrera , Andres Freund , Ashutosh Bapat , Peter Eisentraut , Petr Jelinek , PostgreSQL Hackers Subject: Re: Decoding speculative insert with toast leaks memory In-reply-to: References: <648020.1623854904@sss.pgh.pa.us> <7dab0929-a966-0c0a-4726-878fced2fe00@enterpri! sedb.com> <2161205.1624459891@sss.pgh.pa.us> Comments: In-reply-to Amit Kapila message dated "Thu, 24 Jun 2021 08:45:48 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2569712.1624508715.1@sss.pgh.pa.us> Date: Thu, 24 Jun 2021 00:25:15 -0400 Message-ID: <2569713.1624508715@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Amit Kapila writes: >> I think it's OK in HEAD. I agree we shouldn't do it like that >> in the back branches. > Okay, I'll change this in back branches and HEAD to keep the code > consistent, or do you think it is better to retain the order in HEAD > as it is and just change it for back-branches? As I said, I'd keep the natural ordering in HEAD. regards, tom lane