Subject: Re: psql - add SHOW_ALL_RESULTS option
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com>
 <20210412193301.GA11204@alvherre.pgsql> <YHeVHH0wVcRwdogL@paquier.xyz>
 <3738387.1618451507@sss.pgh.pa.us>
 <alpine.DEB.2.22.394.2104151336060.191178@pseudo>
 <451a2111-3757-c511-9413-8f8af531a167@enterprisedb.com>
 <alpine.DEB.2.22.394.2106121130400.4105466@pseudo>
 <CALDaNm0+pzGgp-M1mAoUVYRtjadbWYuB96J8RaV9iH3+HA8FTA@mail.gmail.com>
 <alpine.DEB.2.22.394.2107151742300.1705285@pseudo>
 <18c78a01-4a34-9dd4-f78b-6860f1420c8e@enterprisedb.com>
 <alpine.DEB.2.22.394.2107221655020.25741@pseudo>
 <6954328d-96f2-77f7-735f-7ce493a40949@enterprisedb.com>
 <alpine.DEB.2.22.394.2109251058000.3216312@pseudo>
 <alpine.DEB.2.22.394.2110021622530.2817726@pseudo>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <2570e2ae-fa0f-aac9-f72f-bb59a9983a20@enterprisedb.com>
Date: Fri, 8 Oct 2021 14:15:31 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2110021622530.2817726@pseudo>
Content-Type: multipart/mixed;
 boundary="------------26D2DAE88A07B42478BD193F"
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/2570e2ae-fa0f-aac9-f72f-bb59a9983a20%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------26D2DAE88A07B42478BD193F
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

On 02.10.21 16:31, Fabien COELHO wrote:
>> Attached v9 integrates your tests and makes them work.
> 
> Attached v11 is a rebase.

This patch still has a few of the problems reported earlier this year.

In [0], it was reported that certain replication commands result in 
infinite loops because of faulty error handling.  This still happens.  I 
wrote a test for it, attached here.  (I threw in a few more basic tests, 
just to have some more coverage that was lacking, and to have a file to 
put the new test in.)

In [1], it was reported that server crashes produce duplicate error 
messages.  This also still happens.  I didn't write a test for it, maybe 
you have an idea.  (Obviously, we could check whether the error message 
is literally there twice in the output, but that doesn't seem very 
general.)  But it's easy to test manually: just have psql connect, shut 
down the server, then run a query.

Additionally, I looked into the Coverity issue reported in [2].  That 
one is fixed, but I figured it would be good to be able to check your 
patches with a static analyzer in a similar way.  I don't have the 
ability to run Coverity locally, so I looked at scan-build and fixed a 
few minor warnings, also attached as a patch.  Your current patch 
appears to be okay in that regard.


[0]: 
https://www.postgresql.org/message-id/69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com

[1]: https://www.postgresql.org/message-id/2902362.1618244606@sss.pgh.pa.us

[2]: https://www.postgresql.org/message-id/2680034.1618157764@sss.pgh.pa.us

--------------26D2DAE88A07B42478BD193F
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="0001-psql-More-tests.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-psql-More-tests.patch"