Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiXmV-006nN6-AW for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Sep 2023 10:16:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qiXmT-008ajO-LC for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Sep 2023 10:16:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiXmT-008aj1-0D for pgsql-hackers@lists.postgresql.org; Tue, 19 Sep 2023 10:16:33 +0000 Received: from rock.pinaraf.info ([109.190.54.247]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiXmO-005QL2-Tf for pgsql-hackers@lists.postgresql.org; Tue, 19 Sep 2023 10:16:31 +0000 Received: from peanuts2.localnet (unknown [IPv6:2001:41d0:fc0b:e300:264b:feff:fe05:380b]) by rock.pinaraf.info (Postfix) with ESMTPSA id 4Rqcxm3GGRz20KQ; Tue, 19 Sep 2023 12:15:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pinaraf.info; s=rock; t=1695118556; bh=Dul/9nUXy6hZy1G8Lz1Hs732PhqDbD/CPsKMtVVCCzE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ICwI9X16MTQu3OS+asy4tsXwDok6oXPP40W8u8aMvgmTjD5srKAenlZg4gVKt36F6 /uy51tU7DuzdOzfbHzqbqlWzVS/nlhaYwt+BuTrlFhC8hnreQlPBcRTGqt6AoYGPrD 8EZoHlB/YaTR3kxI6YpphxApLeZ2yklfdh2Z5fpyjdWGlJ2PiEbGVwuLDE5h2xBJpA ryY79MIvGEHLPnY20jDKOpvT/7r/WBFdNOmEpEiT8zSUBa3loK1D5s+oYFENpW8/85 zhQMQM7SZWO1vwAv07RKRoYwE2Olvhn/6x8ABhMLBo7nwAv48Cc5vgGepmB3R1WRRO EJxiUIbe5RcoQ== From: Pierre Ducroquet To: Nathan Bossart Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Improvements in pg_dump/pg_restore toc format and performances Date: Tue, 19 Sep 2023 12:15:55 +0200 Message-ID: <2575263.Lt9SDvczpP@peanuts2> In-Reply-To: <20230918215442.GB2661288@nathanxps13> References: <2656000.KRxA6XjA2N@peanuts2> <20230918215247.GA2661288@nathanxps13> <20230918215442.GB2661288@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart4294444.ejJDZkT8p0" Content-Transfer-Encoding: 7Bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --nextPart4294444.ejJDZkT8p0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday, September 18, 2023 11:54:42 PM CEST Nathan Bossart wrote: > On Mon, Sep 18, 2023 at 02:52:47PM -0700, Nathan Bossart wrote: > > On Thu, Jul 27, 2023 at 10:51:11AM +0200, Pierre Ducroquet wrote: > >> I ended up writing several patches that shaved some time for pg_restore > >> -l, > >> and reduced the toc.dat size. > > > > I've only just started taking a look at these patches, and I intend to do > > a > > more thorough review in the hopefully-not-too-distant future. > > Since cfbot is failing on some pg_upgrade and pg_dump tests, I've set this > to waiting-on-author. Attached updated patches fix this regression, I'm sorry I missed that. --nextPart4294444.ejJDZkT8p0 Content-Disposition: attachment; filename="0001-drop-has-oids-field-instead-of-having-static-values.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="x-UTF_8J"; name="0001-drop-has-oids-field-instead-of-having-static-values.patch"