Message-ID: <257b266b-38e5-a8c2-08cb-7a131cd39be5@gmail.com>
Date: Sun, 7 Jan 2024 17:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: Add a perl function in Cluster.pm to generate WAL
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Euler Taveira <euler@eulerto.com>,
 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@lists.postgresql.org,
 Andres Freund <andres@anarazel.de>,
 Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
References: <3a6978d6-e4fc-4014-b5f7-45db53d8fa53@app.fastmail.com>
 <ZYEaLlhZ5lgTqsaQ@paquier.xyz>
 <CALj2ACXppTLS1pKa=M-h-VxWHSTo4iJvHYik_J+pLQxdeLMAzQ@mail.gmail.com>
 <ZYIgg55UyDS56Y9l@paquier.xyz>
 <5d160064-8cbe-4b32-9c55-c983b1f63b12@app.fastmail.com>
 <ZYOTKV1MV7gDYpCV@paquier.xyz> <370894.1704325169@sss.pgh.pa.us>
 <2e203472-72b5-1b55-377a-824c3f28b190@gmail.com>
 <ZZdD0U0_cSZT4ZhA@paquier.xyz>
 <2d39b5fa-ba90-48c8-4cde-ecba4a62fa3b@gmail.com>
 <ZZpOenv6gv8TdZLE@paquier.xyz>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <ZZpOenv6gv8TdZLE@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/257b266b-38e5-a8c2-08cb-7a131cd39be5%40gmail.com>
Precedence: bulk

07.01.2024 10:10, Michael Paquier wrote:
> On Fri, Jan 05, 2024 at 11:00:00PM +0300, Alexander Lakhin wrote:
>> Your suspicion was proved right. After
>> git show c161ab74f src/test/recovery/t/035_standby_logical_decoding.pl  | git apply -R
>> 20 iterations with 20 tests in parallel performed successfully for me
>> (twice).
>>
>> So it looks like c161ab74f really made the things worse.

After more waiting, I saw the test failure (with c161ab74f reverted) on
iteration 17 in VM where one test run takes up to 800 seconds.

> We have two different failures here, one when VACUUM fails for a
> shared relation:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2024-01-03%2017%3A09%3A27
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2024-01-01%2020%3A10%3A18
>
> And the second failure happens for VACUUM FULL with a shared relation:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2024-01-03%2020%3A07%3A15
>
> In the second case, the VACUUM FULL happens *BEFORE* the new
> advance_wal(), making c161ab74f unrelated, no?
>
> Anyway, if one looks at the buildfarm logs, this failure is more
> ancient than c161ab74f.  We have many of them before that, some
> reported back in October:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2023-10-19%2000%3A44%3A58
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2023-10-30%2013%3A39%3A20

Yes, I wrote exactly about that upthread and referenced my previous
investigation. But what I'm observing now, is that the failure probability
greatly increased with c161ab74f, so something really changed in the test
behaviour. (I need a couple of days to investigate this.)

Best regards,
Alexander