Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sO5ur-00CJZM-Bv for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Jul 2024 01:33:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sO5up-00EGe1-54 for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Jul 2024 01:33:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sO5uo-00EGdt-Ra for pgsql-hackers@lists.postgresql.org; Mon, 01 Jul 2024 01:33:11 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sO5um-003wxS-HQ for pgsql-hackers@lists.postgresql.org; Mon, 01 Jul 2024 01:33:09 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 4611Wv0K2581871; Sun, 30 Jun 2024 21:32:57 -0400 From: Tom Lane To: Noah Misch cc: Andrew Dunstan , Peter Eisentraut , Alexander Lakhin , Euler Taveira , Amit Kapila , Shlok Kyal , Tomas Vondra , "kuroda.hayato@fujitsu.com" , Bharath Rupireddy , "pgsql-hackers@lists.postgresql.org" , Michael Paquier , Andres Freund , Ashutosh Bapat , =?iso-8859-1?Q?Fabr=EDzio?= de Royes Mello , vignesh C Subject: Re: speed up a logical replica setup In-reply-to: <20240630210817.51.nmisch@google.com> References: <5da4b286-e570-4341-8262-92d763f6b1a4@app.fastmail.com> <776c5cac-5ef5-4001-b1bc-5b698bc0c62a@app.fastmail.com> <3c024250-3f13-4f4d-b8e9-55f176db4abf@eisentraut.org> <0dffca12-bf17-4a7a-334d-225569de5e6e@gmail.com> <2377319.1719766794@sss.pgh.pa.us> <2507765.1719772840@sss.pgh.pa.us> <2509767.1719773880@sss.pgh.pa.us> <20240630192534.11.nmisch@google.com> <2522388.1719781312@sss.pgh.pa.us> <20240630210817.51.nmisch@google.com> Comments: In-reply-to Noah Misch message dated "Sun, 30 Jun 2024 14:08:17 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2581869.1719797577.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 30 Jun 2024 21:32:57 -0400 Message-ID: <2581870.1719797577@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Noah Misch writes: > On Sun, Jun 30, 2024 at 05:01:52PM -0400, Tom Lane wrote: >> I'm tempted to lobotomize the new test case on Windows until >> we have that resolved. > Sounds fine. The pg_upgrade suite adequately tests appendShellString() = and > appendConnStrVal() with the larger character repertoire, so it's enough = for > pg_createsubscriber to test just a space or so. Hmph ... according to [1], 545082091 was not enough to fix this. I guess that old version of IPC::Run also misbehaves for cases involving backslash, single quote, and/or some other special characters? regards, tom lane [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dfairywren&dt= =3D2024-07-01%2000%3A03%3A05