From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
cc: Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
        Thomas Munro <thomas.munro@gmail.com>,
        "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
        Stephen Frost <sfrost@snowman.net>,
        Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>,
        Dilip Kumar <dilipbalaut@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_amcheck contrib application
In-reply-to: <2574324.1615611372@sss.pgh.pa.us>
References: <BA592F2D-F928-46FF-9516-2B827F067F57@enterprisedb.com>
 <CA+TgmoZtTZRE6Mzmwt8VEZD0G5NVbhiJEsHW2YGmmqzJUR_KwA@mail.gmail.com>
 <130B2AED-8322-47E6-AD3F-1263E5E18C80@enterprisedb.com>
 <CA+TgmoZgdsVo9ji_Bc7GVvEqGMapC1Hqyuy6CLV-3oyE7HapRA@mail.gmail.com>
 <BC7728FA-C21D-4E25-A266-E94873637354@enterprisedb.com>
 <CA+TgmobwDwvqbpc0OF8MNzQuwAJ2X1D0qEMdBEXXbmmFfzP9+Q@mail.gmail.com>
 <E8A89327-C1B1-4AE2-AEC6-871D39843627@enterprisedb.com>
 <CA+TgmoakvqTJNCSXQ0Y+pMBa33Gmf2o53WGg816eFC7ju3MWRQ@mail.gmail.com>
 <CA+TgmoZGk-mmV1xz=qOcxQ5fGtdK0_HVB2c8pVDUbMSaK8dM9A@mail.gmail.com>
 <53F089E8-F0E5-4FC9-A9DE-3D6377FA39C4@enterprisedb.com>
 <CA+TgmobrSJCx3PgUAYqOcqDjAN+SCjOJfJ6umGgkpp9sqQauSQ@mail.gmail.com>
 <E9EE1C23-9C17-45DF-8C0B-D6BE16CF18AF@enterprisedb.com>
 <CA+TgmobTsaZxiyqb3On-nYcS+TKXebb2sHMUAoyn-vviT8kevA@mail.gmail.com>
 <CAH2-WzmZJ3MWjaSEaysmkP8A7WL_TiCwOS8eT88yc-bwHgLOKg@mail.gmail.com>
 <CAH2-WznpwULZ3uJ1_6WXvNMXYbOy8k8tYs3r=qSdGmZeRd6tDw@mail.gmail.com>
 <CA+TgmoZUJ4j31CbnUz!
 ! -DpBBq_DVoaYcuG5XB7hP71+uQ=js_KQ@mail.gmail.com>
 <CA+TgmoZ1DP0pkLyuG9y7Jtn2v7N-+dnVxbvBAT__u4-d=UYmbw@mail.gmail.com>
 <A80D68F6-E38F-482D-9522-E2FB6AAFE8A1@enterprisedb.com>
 <CA+TgmoY3_U=QuQWo4DArBSp+tg2MiCHLwDN_9U2H_iTxj3UcjA@mail.gmail.com>
 <9E76E46A-48B2-4869-BD0C-422204C1F767@enterprisedb.com>
 <F0A1FD70-A2F4-4528-8A03-8650CAEC0554@enterprisedb.com>
 <CA+TgmoYoW2NNQC5qzEfsR9cYWpigqQgP_h5MZCLVt1XRbsXTXQ@mail.gmail.com>
 <C37D28BA-3BA3-4776-B812-17F05F3472D8@enterprisedb.com>
 <2574324.1615611372@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 12 Mar 2021 23:56:12 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2588077.1615613250.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 13 Mar 2021 00:27:30 -0500
Message-ID: <2588078.1615613250@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2588078.1615613250%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> ... btw, prairiedog (which has a rather old Perl) has a
> different complaint:
> Invalid type 'q' in unpack at t/004_verify_heapam.pl line 104.

Hmm ... "man perlfunc" on that system quoth

                   q   A signed quad (64-bit) value.
                   Q   An unsigned quad value.
                         (Quads are available only if your system supports=
 64-bit
                          integer values _and_ if Perl has been compiled t=
o support those.
                          Causes a fatal error otherwise.)

It does not seem unreasonable for us to rely on Perl having that
in 2021, so I'll see about upgrading this perl installation.

(I suppose gaur will need it too, sigh.)

			regards, tom lane