From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Raiskup <praiskup@redhat.com>
cc: Robert Haas <robertmhaas@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Devrim =?ISO-8859-1?Q?G=DCND=DCZ?= <devrim@gunduz.org>
Subject: Re: plruby: rb_iterate symbol clash with libruby.so
In-reply-to: <5127122.UsUPqPCgps@nb.usersys.redhat.com>
References: <4738198.8KVIIDhgEB@nb.usersys.redhat.com>
 <22881.1541515786@sss.pgh.pa.us> <28762.1541528901@sss.pgh.pa.us>
 <5127122.UsUPqPCgps@nb.usersys.redhat.com>
Comments: In-reply-to Pavel Raiskup <praiskup@redhat.com>
	message dated "Wed, 07 Nov 2018 13:55:57 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <25953.1541600731.1@sss.pgh.pa.us>
Date: Wed, 07 Nov 2018 09:25:31 -0500
Message-ID: <25954.1541600731@sss.pgh.pa.us>
Precedence: bulk

Pavel Raiskup <praiskup@redhat.com> writes:
> On Tuesday, November 6, 2018 7:28:21 PM CET Tom Lane wrote:
>> Done.  I realized that the immediate problem, rb_iterate(), was only
>> added as of PG v10, which may explain why we hadn't heard complaints
>> about this till now.  So I've made the change only as far back as v10.

> The 'rb_iterate' seems to exist at least in REL9_2_STABLE branch, so it is
> probably much older.

Oh!  Hmm ... I think I jumped to conclusions when the part of my patch
that touched struct RBTreeIterator failed to apply.  But you're right,
rb_iterate has been there since 9.0 now that I look more carefully.
So we really ought to back-patch further.  However:

> That
> said, I'm still not sure how this could work before ...  Maybe it has not
> been working for some time.

Yeah, I'm now mighty confused about this as well.  PL/Ruby is pretty old
too, so how come nobody noticed this before?  Is its rb_iterate call in
someplace that hardly gets any use?

			regards, tom lane