Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\))
Subject: Re: Small patch modifying variable name to reflect the logic involved
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <C37DEA93-26D9-49C6-AAB6-39AEB6B046DD@yesql.se>
Date: Fri, 15 Sep 2023 19:50:51 +0200
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <25C2B047-66B4-4291-A26B-B42359D91A5C@yesql.se>
References: <CAPMWgZ9f9o8awrQpjo8oxnNQ=bMDVPx00NE0QcDzvHD_ZrdLPw@mail.gmail.com>
 <C37DEA93-26D9-49C6-AAB6-39AEB6B046DD@yesql.se>
To: Krishnakumar R <kksrcv001@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/25C2B047-66B4-4291-A26B-B42359D91A5C%40yesql.se>
Precedence: bulk

> On 14 Sep 2023, at 11:30, Daniel Gustafsson <daniel@yesql.se> wrote:
>=20
>> On 14 Sep 2023, at 08:28, Krishnakumar R <kksrcv001@gmail.com> wrote:
>=20
>> Please find a small patch to improve code readability by modifying
>> variable name to reflect the logic involved - finding diff between =
end
>> and start time of WAL sync.
>=20
> -	INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_sync_time, duration, =
start);
> +	INSTR_TIME_SET_CURRENT(end);
> +	INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_sync_time, end, =
start);
>=20
> Agreed, the duration is the result of the INSTR_TIME_ACCUM_DIFF =
calculation,
> not what's stored in the instr_time variable.

And done, with a small fixup to handle another occurrence in the same =
file.

--
Daniel Gustafsson