Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gXv80-00026p-TU for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Dec 2018 21:36:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gXv7y-0008KQ-2K for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Dec 2018 21:36:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gXv7x-0008E8-G0 for pgsql-hackers@lists.postgresql.org; Fri, 14 Dec 2018 21:36:09 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gXv7p-0005oM-Hr for pgsql-hackers@lists.postgresql.org; Fri, 14 Dec 2018 21:36:08 +0000 Received: by mail-wr1-x434.google.com with SMTP id t6so6592486wrr.12 for ; Fri, 14 Dec 2018 13:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Bl0fq5RR+OrXWHUb3ibIfQh1F4yuOwAUjUymlQNL7Ns=; b=FdFt5e6vV5le7+1Z+IGyUckj+KUdsumhzwlW2bxZE97Ddt8RWoI/YKoNdF7RMXocuF JYlaGu+VeSojT8Rx50EWi/gyv/hphdyl9NNHkSMqWAseR8gWkEaOzmF/eC1MolLBRrCh 4REduFYl8enBXBwFGkHinArGEKZksOCablwpeqX7n5tbnKiEQgIsc/0ChkcoUWg2D75X toM+dJH2VYo29ORwK7sGNMt4a3WxBoClYU3A9UBIlrghXahG66GNZ/zlSk03k1tYhhHN n32lncqjyD2ai2Pxglgd7jshzDL6lCkKET+W3JVkpc8z42sqK3rnWFC3ia/ncpPi1P0C E9sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Bl0fq5RR+OrXWHUb3ibIfQh1F4yuOwAUjUymlQNL7Ns=; b=IIdjVjQDXmXNyfWH2MHc8js7g/jraNqh1hasxhtDgTJ8uUQuKvOoZ4vdAEyeu//rQX A5UndSU33maEk7meUU2i9VK9oGvxNlwTT2uxsB8OoKJHTeBSDJCXEZhMQrCe+yA+Khkd LYGb9hbMQFHXpwy+3oQ9hgFZJNFdBjzHkdQVbKX1kDhdTRAkKg3YVB2kl0ojqIrHEAfi 5sEIla6+jpcjS6Nrpy2KdOKybF98yMaITzDAjivi53CZHj5KnjB50F4exIQVXgU7unPz mKWCaJrtcrzPlM3YKRuuER2k+IQxTRPMZwN1f2wN+g03GEVAVOV49SoDsX5HjG13zDvY evzQ== X-Gm-Message-State: AA+aEWYyaFneMJlj6j2uCpap2VuwkQr/wLOKRHnNp5DNvm+HdC8zp+Gp 2fZwzDiZ/m+YFcHHodVSW/wrewfP56X8myi7IfrL3HrSk+JXzcNYmoVqeSwEtyStKkiZKypG0a7 aEkAqr52fUCvQW+ywZE3IFR4b+xchdnfrV6I+eZHT+jqPMIqHVx6VClexF4L5aCM9zkI2eB94Ft EsOBCW1El42t8UJrzIr6TuMQ== X-Google-Smtp-Source: AFSGD/W/MoIGuQynewyz4qz4Umd0pN348z2tEkG0cwWK+x/1yjwG3cDhedax/lnLjbYLsHSMgj1rzA== X-Received: by 2002:adf:e488:: with SMTP id i8mr3998285wrm.10.1544823359329; Fri, 14 Dec 2018 13:35:59 -0800 (PST) Received: from [10.137.2.19] (ip-86-49-251-50.net.upcbroadband.cz. [86.49.251.50]) by smtp.gmail.com with ESMTPSA id v16sm5374547wrs.75.2018.12.14.13.35.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Dec 2018 13:35:58 -0800 (PST) Subject: Re: valgrind issues on Fedora 28 To: Tom Lane Cc: Alvaro Herrera , pgsql-hackers@lists.postgresql.org References: <20181106173527.omm63tiaguxft7mg@alvherre.pgsql> <23c8e539-6777-1793-0939-12e73cb98314@2ndquadrant.com> <9063c043-83cd-b439-a928-622a743edd2c@2ndquadrant.com> <16353.1544760625@sss.pgh.pa.us> <4721dbaf-b922-9e30-e635-00f06512edac@2ndquadrant.com> <11849.1544803095@sss.pgh.pa.us> From: Tomas Vondra Message-ID: <25de4d8b-2192-20f0-7d30-6c5b79ddf716@2ndquadrant.com> Date: Fri, 14 Dec 2018 22:35:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <11849.1544803095@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 12/14/18 4:58 PM, Tom Lane wrote: > ... > > In general, I'm not particularly on board with our valgrind.supp > carrying suppressions for code outside our own code base: I think > that's assuming WAY too much about which version of what is installed > on a particular box. > Fair point. > Maybe we could do something to make it simpler to have custom > suppressions? Not sure what, though. > I was thinking that perhaps we could allows specifying path to extra suppressions and pass that to valgrind. But we don't actually invoke valgrind, that's something people do on their own anyway - so we don't have anywhere to pass the path to. And whoever invokes valgrind can simply stick it directly into the command they're using (as it allows specifying multiple --suppressions= options). Or perhaps just put it into ~/.valgrindrc. So perhaps we should simply revert that commit and be done with it. One place that will need to solve it is buildfarm client, but it could pick either of the options I mentioned. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services