Feedback-ID: ie0a040ee:Fastmail
Message-ID: <25e39ef4-c989-4751-b595-339b1857fda7@eisentraut.org>
Date: Thu, 25 Jan 2024 07:35:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: make dist using git archive
Content-Language: en-US
To: Tristan Partin <tristan@neon.tech>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <40e80f77-a294-4f29-a16f-e21bc7bc75fc@eisentraut.org>
 <CYLI6IZ5RAVR.3RBBF4F3P8MHX@neon.tech>
 <02714192-6eba-4145-ac1c-0a245801014f@eisentraut.org>
 <CYN2MF9LPZFX.3P1LF1G55RXM4@neon.tech> <CYN4PXK5J7KP.247K22MR0MM1G@neon.tech>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CYN4PXK5J7KP.247K22MR0MM1G@neon.tech>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/25e39ef4-c989-4751-b595-339b1857fda7%40eisentraut.org>
Precedence: bulk

On 24.01.24 18:57, Tristan Partin wrote:
>> > 4. Meson uses git archive internally, but then unpacks and repacks 
>> the > archive, which loses the ability to use git get-tar-commit-id.
> 
> Because Meson allows projects to distribute arbitrary files via 
> meson.add_dist_script(), and can include subprojects via `meson dist 
> --include-subprojects`, this doesn't seem like an easily solvable problem.

git archive has the --add-file option, which can probably do the same 
thing.  Subprojects are another thing, but obviously are more rarely used.

> I think the solution to point 4 is to not unpack/repack if there are no 
> dist scripts and/or subprojects to distribute. I can take a look at this 
> later. I think this would also solve points 1, 2, 5, and 6 because at 
> that point meson is just calling git-archive.

I think that would be a useful direction.