Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qxt0s-0046BB-WA
	for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Oct 2023 17:58:51 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1qxt0p-003cxU-MA
	for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Oct 2023 17:58:47 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1qxt0p-003cxM-CS
	for pgsql-hackers@lists.postgresql.org; Tue, 31 Oct 2023 17:58:47 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1qxt0i-003K76-Gy
	for pgsql-hackers@postgresql.org; Tue, 31 Oct 2023 17:58:45 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 39VHwYoc2604998;
	Tue, 31 Oct 2023 13:58:34 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: Yugo NAGATA <nagata@sraoss.co.jp>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers@postgresql.org
Subject: Re: Question about non-blocking mode in libpq
In-reply-to: <ZUEyKtrtl3IoTwWW@momjian.us>
References: <20210719231129.b2ab655c0d0e80545274c86f@sraoss.co.jp> <202107201605.b3hmz4g6uqqz@alvherre.pgsql> <20210721101509.7e70e0f801a4457a2f6a6174@sraoss.co.jp> <ZUEyKtrtl3IoTwWW@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Tue, 31 Oct 2023 12:58:18 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2604996.1698775114.1@sss.pgh.pa.us>
Date: Tue, 31 Oct 2023 13:58:34 -0400
Message-ID: <2604997.1698775114@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2604997.1698775114%40sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> I modified your patch, attached, that I would like to apply to all
> supported versions.

This seems to have lost the information about what to do if these
functions fail.  I think probably the only possible failure cause
in nonblock mode is "unable to enlarge the buffer because OOM",
but that's certainly not the same thing as "cannot fail".

			regards, tom lane