Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eZMVb-0006DZ-Cg
	for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Jan 2018 19:57:59 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eZMVa-0001iN-V2
	for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Jan 2018 19:57:58 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eZMVa-0001iC-OQ
	for pgsql-hackers@lists.postgresql.org; Wed, 10 Jan 2018 19:57:58 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eZMVY-0000pe-2L
	for pgsql-hackers@lists.postgresql.org; Wed, 10 Jan 2018 19:57:58 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w0AJvpBW026079;
	Wed, 10 Jan 2018 14:57:51 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Dubious shortcut in ckpt_buforder_comparator()
In-reply-to: <20180110193407.ub73iszdoi4zh233@alap3.anarazel.de>
References: <18437.1515607610@sss.pgh.pa.us>
 <20180110193407.ub73iszdoi4zh233@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 10 Jan 2018 11:34:07 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <26077.1515614271.1@sss.pgh.pa.us>
Date: Wed, 10 Jan 2018 14:57:51 -0500
Message-ID: <26078.1515614271@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2018-01-10 13:06:50 -0500, Tom Lane wrote:
>> So I think we should get rid of that micro-optimization, which is
>> probably useless anyway from a performance standpoint, and do the
>> comparison honestly.  Any objections?

> No, absolutely none. You're going to change it?

Will do.

			regards, tom lane