From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Antonin Houska <ah@cybertec.at>, Justin Pryzby <pryzby@telsasoft.com>,
        Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
        Matthias van de Meent <boekewurm+postgres@gmail.com>,
        pgsql-hackers@lists.postgresql.org, Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: <aeYvFBkWT0V2_IUZ@alvherre.pgsql>
References: <aeYvFBkWT0V2_IUZ@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Mon, 20 Apr 2026 15:54:52 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <260900.1776696126.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 20 Apr 2026 10:42:06 -0400
Message-ID: <260901.1776696126@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/260901.1776696126%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2026-Apr-20, Antonin Houska wrote:
>> Is this an attempt to disable REPACK (CONCURRENTLY)? That would require
>> wal_level=3Dminimal (due to commit 67c20979ce). In which way does REPAC=
K seem to
>> break test_plan_advice?

> No, quite the contrary.  That test normally runs with wal_level=3Dminima=
l,
> which causes REPACK to complain that it cannot start logical
> decoding.

So what you're saying is that the core regression tests will now fail
with wal_level=3Dminimal?  I don't see how that can possibly be
considered acceptable from a global standpoint; we might as well
remove wal_level=3Dminimal, because it will never again get tested.

I think you need to move these tests out into some other test suite
(or make a new one).

			regards, tom lane