Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntYxV-00058A-Ks for pgsql-hackers@arkaria.postgresql.org; Tue, 24 May 2022 18:08:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ntYxU-0000Ny-4r for pgsql-hackers@arkaria.postgresql.org; Tue, 24 May 2022 18:08:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntYxS-0000BH-Tb for pgsql-hackers@lists.postgresql.org; Tue, 24 May 2022 18:08:39 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntYxN-0007F5-8c for pgsql-hackers@postgresql.org; Tue, 24 May 2022 18:08:37 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 871655C0404; Tue, 24 May 2022 14:08:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 24 May 2022 14:08:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653415711; x= 1653502111; bh=9MRmGuFpKJ0YtcnHPCH7ZzMvdb5zize7EAxX+jiL1kk=; b=s VTAZMFnDs/liqDpYf7VELFAkkOpFLEV3Oa7ylrYsb1tIKFPhPeDbz0yG3auO2Atm 1iQDD24iBL9qJUeR8OPx/GR7tFzEj+N5MNRG9te+K0D5+NfOUxPgk3FJXTNeSBDY c/grvJxHS7A7h/0pzwzzO6H7ggUeyvMnk1Py56cdG1BuxUyfgRFvSYd9QidM0q4S Fy6gfmmBNpY5bwNc6Ae85rfYgQ6dqGoUQUaEv1ULMMGrx4hcvurqBOtLwgRoBMNC 09cqqx9M2l3i4Qv5SsiRkyStIyNHcgh1EX70x27Yffwj+nCiL2qVCqGEAAMQ+M52 mmB8S8LvU5YohChSVxrLA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeefgdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehleffgeegudejteei hfelteduvdeifffhffdvjedvffegjeekudeludehudeifeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 May 2022 14:08:27 -0400 (EDT) Message-ID: <261aa7b4-e70b-7a1a-a1e1-03c063911acc@enterprisedb.com> Date: Tue, 24 May 2022 20:08:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [RFC] building postgres with meson -v8 Content-Language: en-US To: Andres Freund Cc: pgsql-hackers@postgresql.org References: <1037188.1648508299@sss.pgh.pa.us> <20220328231140.7ylalxc76zli6p46@alap3.anarazel.de> <20f604f6-40be-e17b-87ac-32737743c63d@enterprisedb.com> <20220429174633.6io23mlwphdqdakv@alap3.anarazel.de> <8ced34e6-7abf-b3b2-3770-0487794753c5@enterprisedb.com> <20220502163602.smlwfhh2cnutxora@alap3.anarazel.de> <63255c46-78cb-f018-8ae0-4a14928fcfdc@enterprisedb.com> <20220518194827.wsmoig5jkq5pltob@alap3.anarazel.de> From: Peter Eisentraut In-Reply-To: <20220518194827.wsmoig5jkq5pltob@alap3.anarazel.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 18.05.22 21:48, Andres Freund wrote: > - CONFIGURE_ARGS - empty in meson, not clear what to fill it with Ok to leave empty for now. > - GETTIMEOFDAY_1ARG - test doesn't exist - I suspect it might not be necessary Might be obsolete, consider removing. > - PACKAGE_STRING, PACKAGE_TARNAME - unclear if they should be implemented? leave out for now > - AC_APPLE_UNIVERSAL_BUILD logic - which I don't think we need? no > - "missing" a bunch of defines that don't appear to be referenced: Yeah, looks like these are implicitly defined by some autoconf check but then the result is only used within configure.ac itself, so isn't needed afterwards. > - meson additional defines, seems harmless: > HAVE_GETTIMEOFDAY - only defined on windows rn > HAVE_SHM_UNLINK > HAVE_SSL_NEW > HAVE_STRTOQ > HAVE_STRTOUQ > HAVE_CRYPTO_NEW_EX_DATA Yeah, that's the opposite of the previous. I don't see any other issues in pg_config.h either. Obviously, some niche platforms might uncover some issues, but it looks good for now.