From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>,
        Jelte Fennema <postgres@jeltef.nl>,
        Michael Paquier <michael@paquier.xyz>,
        "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>, Noah Misch <noah@leadboat.com>,
        Bruce Momjian <bruce@momjian.us>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <CAH2-WznZ4g8mrHCPVr5MBcSFenFnaKPp2K52JvqLt2fjdcR-bg@mail.gmail.com>
References: <CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com> <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net> <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net> <CAH2-WznOKBQ3HvdwvyXHz18T2u-brkE5umDUic4B-2vtavJKqA@mail.gmail.com> <20230811212511.aih23qfthi24zhq4@awork3.anarazel.de> <CAH2-Wz=+23=O6iioUR_k9-mgUoX2kJPOWW5JdOXmd5dCtvinVg@mail.gmail.com> <338202.1691793002@sss.pgh.pa.us> <CAH2-Wz=TNXWQWFgZPehFyPo+9HxxwuHHHYA-ymR+W+kMChM+9Q@mail.gmail.com> <342032.1691794926@sss.pgh.pa.us> <8c4d8afb-cda1-299c-8011-f60cdaff3999@dunslane.net> <20230812211404.sydbwo2juu7vyhtg@awork3.anarazel.de> <530189.1691880417@sss.pgh.pa.us> <CAH2-Wz=OXmLbQ9ykYYSTmadD=fHtn7-ctCqsco7rc2s3Fvx8QQ@mail.gmail.com> <544112.1691886017@sss.pgh.pa.us> <CAH2-WzmueQvoZVScpUcAes3Gq_OGCnOH1RXyMicrMdyaAg6OLA@mail.gmail.com> <CAH2-WznZ4g8mrHCPVr5MBcSFenFnaKPp2K52JvqLt2fjdcR-bg@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Sun, 15 Oct 2023 17:52:17 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2620571.1697503500.1@sss.pgh.pa.us>
Date: Mon, 16 Oct 2023 20:45:00 -0400
Message-ID: <2620572.1697503500@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2620572.1697503500%40sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> There were two independent fixup commits to address complaints from
> koel just today (from two different committers). Plus there was a
> third issue (involving a third committer) this past Wednesday.

> This policy isn't working.

Two thoughts about that:

1. We should not commit indent fixups on behalf of somebody else's
misindented commit.  Peer pressure on committers who aren't being
careful about this is the only way to improve matters; so complain
to the person at fault until they fix it.

2. We could raise awareness of this issue by adding indent verification
to CI testing.  I hesitate to suggest that, though, for a couple of
reasons:
   2a. It seems fairly expensive, though I might be misjudging.
   2b. It's often pretty handy to submit patches that aren't fully
   indent-clean; I have such a patch in flight right now at [1].

2b could be ameliorated by making the indent check be a separate
test process that doesn't obscure the results of other testing.

			regards, tom lane

[1] https://www.postgresql.org/message-id/2617358.1697501956%40sss.pgh.pa.us