public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Chao Li <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Rafia Sabih <[email protected]>
Cc: vignesh C <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Set notice receiver before libpq connection startup
Date: Wed, 27 May 2026 19:56:50 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAHGQGwHnz7FoSx+qQsAHBx_j8Tks+SC-kAPTevrKYfrL08Ee9Q@mail.gmail.com>
	<[email protected]>
	<CALDaNm3UyoQ91gW2bRP4PXnnfAv3GfmCik614-AtQCiEUAjQYw@mail.gmail.com>
	<[email protected]>
	<CA+FpmFdfyBhuiou1uqe94UR3WCg57wM5FsooUx2w27aABGoyag@mail.gmail.com>
	<CAHGQGwHU2E7h7XBCBNK7OJ+OAx7Xkwn+yUb7o5p5GxExi4fzAw@mail.gmail.com>
	<[email protected]>
	<CAHGQGwEvA2a+jXZdVrdybX9OmWguSU4Q8wEhZxWKkDMOZHnuMQ@mail.gmail.com>
	<[email protected]>

On 23.05.26 01:56, Chao Li wrote:
> 
> 
>> On May 22, 2026, at 23:28, Fujii Masao <[email protected]> wrote:
>>
>> On Fri, May 22, 2026 at 11:56 PM Chao Li <[email protected]> wrote:
>>> PFA v4, just removed conn NULL check.
>>
>> Thanks for updating the patch! I've pushed it.
>>
>> Regards,
>>
>> -- 
>> Fujii Masao
> 
> Thanks for pushing and still working hard during the PGConf.

The committed patch violates the .gitattributes whitespace rules:

git show --check 06a5c3cdef02

contrib/postgres_fdw/connection.c:651: indent with spaces.
+                                                   /* expand_dbname = 
*/ false);

It is unfortunate that pgindent produces this layout that contradicts 
the git configuration.  (The current formatting also doesn't look like 
what I would produce in an editor, so I think git is right here.)

Maybe we could reformat this slightly to avoid that?  (unless someone 
wants to try to fix pgindent)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Set notice receiver before libpq connection startup
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox