Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1snCOX-001ju1-Km
	for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Sep 2024 07:31:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1snCOW-00AZR7-Eu
	for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Sep 2024 07:31:36 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1snCOW-00AZQx-5F
	for pgsql-hackers@lists.postgresql.org; Sun, 08 Sep 2024 07:31:36 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1snCOO-0006sJ-K5
	for pgsql-hackers@lists.postgresql.org; Sun, 08 Sep 2024 07:31:35 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 4887VN0U2621244;
	Sun, 8 Sep 2024 03:31:23 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stepan Neretin <sndcppg@gmail.com>
cc: Peter Eisentraut <peter@eisentraut.org>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: SPI_connect, SPI_connect_ext return type
In-reply-to: <CAMaYL5Z8iQea4oonLywEEifB1EzegMabpS0_fMjNz4cOA=7qig@mail.gmail.com>
References: <CAMaYL5Z9Uk8cD9qGz9QaZ2UBJFOu7jFx5Mwbznz-1tBbPDQZow@mail.gmail.com> <3133982.1723299124@sss.pgh.pa.us> <a6fc9639-8f30-4b22-908e-77f415c8cebb@eisentraut.org> <2074782.1725570830@sss.pgh.pa.us> <CAMaYL5Z8iQea4oonLywEEifB1EzegMabpS0_fMjNz4cOA=7qig@mail.gmail.com>
Comments: In-reply-to Stepan Neretin <sndcppg@gmail.com>
	message dated "Sun, 08 Sep 2024 13:35:00 +0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2621242.1725780683.1@sss.pgh.pa.us>
Date: Sun, 08 Sep 2024 03:31:23 -0400
Message-ID: <2621243.1725780683@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2621243.1725780683%40sss.pgh.pa.us>
Precedence: bulk

Stepan Neretin <sndcppg@gmail.com> writes:
>> This combines portions of Stepan's
>> two patches with some additional work (mostly, that he'd missed fixing
>> any of contrib/).

> Thank you for the feedback! I believe the patch looks satisfactory. Should
> we await a review? The changes seem straightforward to me.

I too think it's good to go.  If no one complains or asks for
more time to review, I will push it Monday or so.

			regards, tom lane