From: Nikolay Shaplov <dhyan@nataraj.su>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
 Andres Freund <andres@anarazel.de>
Subject: Re: [HACKERS] [PATCH] Move all am-related reloption code into
 src/backend/access/[am-name] and get rid of relopt_kind for custom AM
Date: Tue, 28 Nov 2017 09:12:01 +0300
Message-ID: <2621611.3GR6eXjdAP@x200m>
User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )
In-Reply-To: 
 <CAB7nPqS+nkYg4uxyTTeZWZjZVW4rTCMAqzzduQNHmDH2GoQC3Q@mail.gmail.com>
References: <20170903094543.kkqdbdjuxwa5z6ji@alvherre.pgsql>
 <CAB7nPqSvJug6XLzHJ898bZSu5DCgYgcWd0iEsdUU3BMXgvwXwg@mail.gmail.com>
 <CAB7nPqS+nkYg4uxyTTeZWZjZVW4rTCMAqzzduQNHmDH2GoQC3Q@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

=D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 28 =D0=BD=D0=BE=
=D1=8F=D0=B1=D1=80=D1=8F 2017 11:23:38 =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=
=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C Michael Paquier =D0=BD=D0=B0=D0=
=BF=D0=B8=D1=81=D0=B0=D0=BB:
> On Tue, Nov 28, 2017 at 11:22 AM, Michael Paquier
>=20
> <michael.paquier@gmail.com> wrote:
> > On Tue, Nov 14, 2017 at 4:44 PM, Michael Paquier
> >=20
> > <michael.paquier@gmail.com> wrote:
> >> On Mon, Oct 30, 2017 at 9:49 AM, Nikolay Shaplov <dhyan@nataraj.su=
>=20
wrote:
> >>> =D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 3 =D1=81=
=D0=B5=D0=BD=D1=82=D1=8F=D0=B1=D1=80=D1=8F 2017 11:45:43 =D0=BF=D0=BE=D0=
=BB=D1=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C Alvaro Herrer=
a
> >>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:
> >>>=20
> >>> Yet another git rebase. This patch can be applied to master branc=
h
> >>> again.
> >>>=20
> >>> For this patch no review needed now, as I will offer part of it (=
one
> >>> that
> >>> refuses to set toast reloptions when there is no TOAST table) as =
a
> >>> separate
> >>> patch.
> >>=20
> >> This patch needs a rebase, there are conflicts with HEAD.
> >=20
> > Bumping the patch to next CF as no updates have happened for the la=
st two
> > weeks.
> Er, returned with feedback.. This will be my last patch for the day.
May be you are right. This patch should be split into smaller patches. =
I will=20
do it bit by bit whet I have time. But I see no reason for the big one =
to=20
remain on commitfest, as it is not for direct commit.

PS. I will do the rebase soon, this patch overlaps with two recent comm=
its. So=20
this require very careful rebasing....


--=20
Do code for fun. Can do it for money (Perl & C/C++ ~10h/week)