Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFFiG-0006h6-Pp for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Jan 2023 14:34:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pFFiF-00073G-M7 for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Jan 2023 14:34:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFFiF-000736-DH for pgsql-hackers@lists.postgresql.org; Tue, 10 Jan 2023 14:34:51 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFFiD-0007OV-2S for pgsql-hackers@postgresql.org; Tue, 10 Jan 2023 14:34:51 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30AEYdUb262405; Tue, 10 Jan 2023 09:34:39 -0500 From: Tom Lane To: Dean Rasheed cc: Paul Ramsey , Fabien COELHO , Michael Paquier , Justin Pryzby , pgsql-hackers@postgresql.org Subject: Re: [PATCH] random_normal function In-reply-to: References: <20221208224623.GQ27893@telsasoft.com> <20221231035804.GJ1153@telsasoft.com> <1682143.1672713508@sss.pgh.pa.us> <1776287.1672764097@sss.pgh.pa.us> <3983784.1673223640@sss.pgh.pa.us> <3996998.1673230641@sss.pgh.pa.us> <4173840.1673290336@sss.pgh.pa.us> <67201.1673307519@sss.pgh.pa.us> Comments: In-reply-to Dean Rasheed message dated "Tue, 10 Jan 2023 08:33:53 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <262403.1673361279.1@sss.pgh.pa.us> Date: Tue, 10 Jan 2023 09:34:39 -0500 Message-ID: <262404.1673361279@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Dean Rasheed writes: > I double-checked the one-in-a-billion claim, and it looks about right > for each test. Thanks for double-checking my arithmetic. > The rest looks good to me, except there's a random non-ASCII character > instead of a hyphen in "Kolmogorov-Smirnov" (because I copy-pasted the > name from some random website). Yeah, I caught that before committing. The AIX buildfarm members were still showing low-order diffs in the random_normal results at extra_float_digits = 0, but they seem OK after reducing it to -1. regards, tom lane